[MDEP-587] test-jar type is incorrectly translated to jar artifact when resolving dependencies

[jira-importer]

Michael O'Connor opened MDEP-587 and commented

When attempting to download a test-jar artifact there seems to be an error in how the artifact coordinates get translated. I think, for example, that ```
foo:bar:1.0.0-SNAPSHOT:test-jar

```foo:bar:1.0.0-SNAPSHOT:jar:tests
``` but instead the plugin is translating it to 
```foo:bar:1.0.0-SNAPSHOT:jar
``` which results in getting an incorrect artifact

To test, I'll use a random artifact from central that has an uploaded tests jar

mvn org.apache.maven.plugins:maven-dependency-plugin:3.0.2:copy -Dartifact=org.neo4j:neo4j-collections:3.3.0:test-jar -DoutputDirectory=/tmp/

---

Affects: 3.0.0, 3.0.1, 3.0.2

1 votes, 3 watchers

[jira-importer]

Karl Heinz Marbaise commented

On the first glance I see your problem...this means that the maven-dependency-plugin must translate all existing combinations of packaging type into extension/classifier. The problem going this direction would be that for each existing plugin which defines a packaging for example maven-jar-plugin, maven-war-plugin, maven-ear-plugin, or maven-jlink-plugin or rpm-maven-plugin etc. those translations must be put into the maven-dependency-plugin to work correctly...I'm not sure if this would be a good idea to do so...an excerpt of existing translations is documented here http://maven.apache.org/ref/current/maven-core/artifact-handlers.html but for rpm-maven-plugin and maven-jlink-plugin it is not there...

If you use the correct combinations of groupId:artifactId:version:packaging:classifier like this:

mvn org.apache.maven.plugins:maven-dependency-plugin:3.0.2:copy -Dartifact=org.neo4j:neo4j-collections:3.3.0:jar:tests -DoutputDirectory=..

[jira-importer]

Michael O'Connor commented

Right I agree that having to translate all existing combinations would be pretty ridiculous. This particular one is actually listed in the default artifact handlers. Its the last one in the table on the link you provided in your comment Karl Heinz Marbaise :-)

I'm just curious if this was an intentional change or not. Since it did work as expected prior to maven-dependency-plugin 3.x. If you run my example command with version 2.10 it will actually work. That was actually how I had noticed the issue, during an upgrade of some outdated plugins in our build

[jira-importer]

Sami Salonen commented

I hit the same issue with artifact of type ejb-client when upgrading plugin from 2.10 to 3.1.1. I did not use classifier, only type in artifactItem configuration for copy goal. With plugin version 2.10 ejb-client artifact was copied, but after plugin upgrade ejb artifact was copied. Problem got solved by adding classifier "client" to artifactItem configuration. With new plugin version it was actually possible to remove the type altogether as functionality was the same with or without it.

[wilx]

This conflicts with PRs #1667 and #1668. We can fix this once those get merged.