[MDEP-736] classifier applyed to other artifactItem

[jira-importer]

Julien CORON opened MDEP-736 and commented

When I use the plugin in the phase "package" and the goal "copy",  with the artifactItem having the classifier "agent", then the other instance of the plugin with the phase "prepare-package" and the goal "copy-dependencies" on the first artifactItem has the same classifier "agent".

 

Example:

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.2.1</version>
<executions>
<execution>
<id>unpack-jolokia</id>
<phase>package</phase>
<goals>
<goal>copy</goal>
</goals>
</execution>
</executions>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.jolokia</groupId>
<artifactId>jolokia-jvm</artifactId>
<version>1.6.0</version>
<type>jar</type>
<classifier>agent</classifier>
<outputDirectory>${project.build.directory}/tmp</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.0.0</version>
<executions>
<execution>
<id>copy-dependencies</id>
<phase>prepare-package</phase>
<goals>
<goal>copy-dependencies</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/tmp</outputDirectory>
<excludeTransitive>false</excludeTransitive>
<includeGroupIds>yyyyyyyy</includeGroupIds>
</configuration>
</execution>
<execution>
<id>unpack-help</id>
<phase>prepare-package</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>aa.bbb.cccc</groupId>
<artifactId>xxxxx</artifactId>
<version>${xxxxxx.version}</version>
<type>jar</type>
<overWrite>true</overWrite>
<outputDirectory>${project.build.directory}/classes/xxxxxxx</outputDirectory>
<includes>**/*</includes>
</artifactItem>

 

--> This artifactItem will inherit the "classifier" = "agent" property, and should not.

 

---

Affects: 3.0.0

[wilx]

This is caused by the duplicate <plugin> declarations and Maven's configuration merging, rather than by maven-dependency-plugin.

Both blocks declare the same groupId:artifactId. Maven warns that the plugin declaration must be unique and merges the blocks. The first block's <configuration> is plugin-level configuration, so it acts as a default for every execution. When Maven combines it with the unpack-help execution configuration, the first <artifactItem> inherits the otherwise unspecified <classifier>agent</classifier> value. An -X run confirms that agent is already present in the final Mojo configuration before the dependency plugin executes.

The POM should declare maven-dependency-plugin once, with one version, and put the Jolokia <artifactItems> configuration inside the copy execution. Each other execution should likewise contain its own <artifactItems> configuration. With that structure, the unpack artifact does not receive a classifier.

There does not appear to be anything actionable in the plugin: it receives the configuration after Maven has already merged it and cannot determine which declaration supplied a value. I suggest closing this issue as a configuration problem rather than a plugin defect.