Support for async in combination testing?

[vbrett]

#114 added the possibility to use verify within an async function, but as far as I can see, you cannot run combination approvals functions such as verify_all_combinations to test an async function.

Now, I'm barely started using this package, so I apologize in advance if I missed the way to do it.
Thanks !

[JayBazuzi]

Are you trying to run them in parallel and then collect them?
You are right that at the moment there is not support for async in combination approvals.
I would suggest joining the sunday mob for this issue. we could probably do it in a single session.
https://github.com/approvals/ApprovalTests.Python/blob/main/docs/Contribute.md

[vbrett]

Let say I want to test this async function

async def myfunction(arg1:int, arg2:bool):
    ...
    return result

I'd like to create this test function:

@pytest.mark.asyncio
async def test_myfunction():
    arg1_values = [0, 15, 999]
    arg2_values = [True, False]

    approvaltests.verify_all_combinations_with_labeled_input(myfunction,
                                                             arg1 = arg1_values,
                                                             arg1 = arg2_values)

Knowing myfunction is connecting to a DB I'm not mocking, I'm not sure running all combinations in parallel is a good approach.

And regarding joining Sunday mob - it's too late for today. I'll see if I can join next week

[JayBazuzi]

What do you think of this? #238

[vbrett]

Hi @JayBazuzi, sorry for replying with a delay - I was not able to look into this until now.

But #238 is exactly what I had in mind.

Thanks for the (very) quick update !