getLines return undefined, getContents return undefined, line count default to 0

Deep Furiya · Deep Furiya · commit c4d5444046f5 · 2025-12-04T13:54:21.000-05:00
diff --git a/src/ai/CfnAI.ts b/src/ai/CfnAI.ts
@@ -58,10 +58,11 @@ export class CfnAI implements SettingsConfigurable, Closeable {
                 throw new Error(`Template not found ${toString(templateFile)}`);
             }
 
-            return await agent.execute(
-                await Prompts.describeTemplate(document.contents()),
-                await this.getToolsWithFallback(),
-            );
+            const content = document.contents();
+            if (!content) {
+                throw new Error('Document content is undefined');
+            }
+            return await agent.execute(await Prompts.describeTemplate(content), await this.getToolsWithFallback());
         });
     }
 
@@ -72,10 +73,11 @@ export class CfnAI implements SettingsConfigurable, Closeable {
                 throw new Error(`Template not found ${toString(templateFile)}`);
             }
 
-            return await agent.execute(
-                await Prompts.optimizeTemplate(document.contents()),
-                await this.getToolsWithFallback(),
-            );
+            const content = document.contents();
+            if (!content) {
+                throw new Error('Document content is undefined');
+            }
+            return await agent.execute(await Prompts.optimizeTemplate(content), await this.getToolsWithFallback());
         });
     }
 
@@ -86,8 +88,12 @@ export class CfnAI implements SettingsConfigurable, Closeable {
                 return;
             }
 
+            const content = document.contents();
+            if (!content) {
+                throw new Error('Document content is undefined');
+            }
             return await agent.execute(
-                await Prompts.analyzeDiagnostic(document.contents(), diagnostics),
+                await Prompts.analyzeDiagnostic(content, diagnostics),
                 await this.getToolsWithFallback(),
             );
         });
@@ -107,6 +113,9 @@ export class CfnAI implements SettingsConfigurable, Closeable {
             }
 
             const templateContent = document.contents();
+            if (!templateContent) {
+                throw new Error('Document content is undefined');
+            }
 
             const resourceTypes = this.relationshipSchemaService.extractResourceTypesFromTemplate(templateContent);
             const relationshipContext = this.relationshipSchemaService.getRelationshipContext(resourceTypes);
diff --git a/src/codeLens/ManagedResourceCodeLens.ts b/src/codeLens/ManagedResourceCodeLens.ts
@@ -28,6 +28,9 @@ export class ManagedResourceCodeLens {
         }
 
         const text = document.getText();
+        if (!text) {
+            return [];
+        }
         const lines = text.split('\n');
 
         for (const [, resourceContext] of resourcesMap) {
diff --git a/src/codeLens/StackActionsCodeLens.ts b/src/codeLens/StackActionsCodeLens.ts
@@ -36,6 +36,9 @@ export function getStackActionsCodeLenses(
 
     let codeLensLine = 0;
     const lines = document.getLines();
+    if (!lines) {
+        return [];
+    }
     for (const [i, line] of lines.entries()) {
         const lineContents = line.trim();
         if (lineContents.length > 0 && !lineContents.startsWith('#')) {
diff --git a/src/context/FileContextManager.ts b/src/context/FileContextManager.ts
@@ -22,8 +22,13 @@ export class FileContextManager {
             return undefined;
         }
 
+        const content = document.contents();
+        if (!content) {
+            return undefined;
+        }
+
         try {
-            return new FileContext(uri, document.documentType, document.contents());
+            return new FileContext(uri, document.documentType, content);
         } catch (error) {
             this.log.error(error, `Failed to create file context ${uri}`);
             return undefined;
diff --git a/src/document/Document.ts b/src/document/Document.ts
@@ -21,10 +21,8 @@ export class Document {
         detectIndentation: boolean = true,
         fallbackTabSize: number = DefaultSettings.editor.tabSize,
     ) {
-        const doc = this.getTextDocument();
-        const { extension, type } = doc
-            ? detectDocumentType(doc.uri, doc.getText())
-            : { extension: '', type: DocumentType.YAML };
+        const doc = this.getTextDocument() as TextDocument;
+        const { extension, type } = detectDocumentType(doc.uri, doc.getText());
 
         this.extension = extension;
         this.documentType = type;
@@ -138,11 +136,11 @@ export class Document {
     }
 
     public getText(range?: Range) {
-        return this.getTextDocument()?.getText(range) ?? '';
+        return this.getTextDocument()?.getText(range);
     }
 
-    public getLines(): string[] {
-        return this.getText().split('\n');
+    public getLines(): string[] | undefined {
+        return this.getText()?.split('\n');
     }
 
     public positionAt(offset: number) {
@@ -158,7 +156,7 @@ export class Document {
     }
 
     public contents() {
-        return this.getTextDocument()?.getText() ?? '';
+        return this.getTextDocument()?.getText();
     }
 
     public metadata(): DocumentMetadata {
@@ -170,7 +168,7 @@ export class Document {
             cfnType: this.cfnFileType,
             languageId: this.languageId ?? '',
             version: this.version ?? 0,
-            lineCount: this.lineCount ?? -1,
+            lineCount: this.lineCount ?? 0,
         };
     }
 
@@ -190,6 +188,9 @@ export class Document {
 
     private detectIndentationFromContent(): number | undefined {
         const content = this.contents();
+        if (!content) {
+            return undefined;
+        }
         const lines = content.split('\n');
 
         const maxLinesToAnalyze = Math.min(lines.length, 30);
diff --git a/src/document/DocumentManager.ts b/src/document/DocumentManager.ts
@@ -176,7 +176,10 @@ export class DocumentManager implements SettingsConfigurable, Closeable {
     private emitDocSizeMetrics() {
         for (const doc of this.documentMap.values()) {
             if (doc.isTemplate()) {
-                this.telemetry.histogram('documents.template.size.bytes', byteSize(doc.contents()), { unit: 'By' });
+                const content = doc.contents();
+                if (content) {
+                    this.telemetry.histogram('documents.template.size.bytes', byteSize(content), { unit: 'By' });
+                }
             }
         }
     }
diff --git a/src/handlers/DocumentHandler.ts b/src/handlers/DocumentHandler.ts
@@ -25,6 +25,10 @@ export function didOpenHandler(components: ServerComponents): (event: TextDocume
         }
 
         const content = document.contents();
+        if (!content) {
+            log.error(`No content found for document ${uri}`);
+            return;
+        }
 
         if (document.isTemplate() || document.cfnFileType === CloudFormationFileType.Empty) {
             try {
@@ -57,6 +61,10 @@ export function didChangeHandler(
         // This is the document AFTER changes
         const document = new Document(textDocument.uri, () => textDocument);
         const finalContent = document.getText();
+        if (!finalContent) {
+            log.error(`No content found for document ${documentUri}`);
+            return;
+        }
 
         const tree = components.syntaxTreeManager.getSyntaxTree(documentUri);
 
diff --git a/src/handlers/StackHandler.ts b/src/handlers/StackHandler.ts
@@ -97,7 +97,7 @@ export function getTemplateArtifactsHandler(
                 components.s3Service,
                 document.documentType,
                 document.uri,
-                document.contents(),
+                document.contents() ?? '',
             );
             const artifacts = template.getTemplateArtifacts();
             return { artifacts };
diff --git a/src/resourceState/ResourceStateImporter.ts b/src/resourceState/ResourceStateImporter.ts
@@ -443,7 +443,16 @@ export class ResourceStateImporter {
         // For JSON without Resources section, check if file is essentially empty
         if (!resourcesSection) {
             try {
-                const parsed = JSON.parse(document.getText()) as Record<string, unknown>;
+                const text = document.getText();
+                if (!text) {
+                    return {
+                        position: { line: 0, character: 0 },
+                        commaPrefixNeeded: false,
+                        newLineSuffixNeeded: false,
+                        replaceEntireFile: true,
+                    };
+                }
+                const parsed = JSON.parse(text) as Record<string, unknown>;
                 const hasContent = Object.keys(parsed).length > 0;
 
                 // If no content, replace entire file
diff --git a/src/stacks/actions/StackActionOperations.ts b/src/stacks/actions/StackActionOperations.ts
@@ -97,14 +97,22 @@ export async function processChangeSet(
         throw new ResponseError(ErrorCodes.InvalidParams, `Document not found: ${params.uri}`);
     }
     let templateBody = document.contents();
+    if (!templateBody) {
+        throw new ResponseError(ErrorCodes.InvalidParams, `Document content is undefined: ${params.uri}`);
+    }
     let templateS3Url: string | undefined;
     let expectedETag: string | undefined;
     try {
         if (params.s3Bucket) {
             const s3KeyPrefix = params.s3Key?.includes('/')
                 ? params.s3Key.slice(0, params.s3Key.lastIndexOf('/'))
                 : undefined;
-            const template = new ArtifactExporter(s3Service, document.documentType, document.uri, document.contents());
+            const template = new ArtifactExporter(
+                s3Service,
+                document.documentType,
+                document.uri,
+                document.contents() ?? '',
+            );
 
             const exportedTemplate = await template.export(params.s3Bucket, s3KeyPrefix);
 
diff --git a/tst/unit/context/FileContextManager.test.ts b/tst/unit/context/FileContextManager.test.ts
@@ -168,16 +168,14 @@ describe('FileContextManager', () => {
                 documentType: DocumentType.YAML,
                 contents: vi.fn().mockReturnValue(''),
             };
-            const mockFileContext = {} as FileContext;
 
             mockDocumentManager.get.returns(mockDocument as any);
             mockDocumentManager.isTemplate.returns(true);
-            MockedFileContext.mockImplementation(() => mockFileContext);
 
             const result = fileContextManager.getFileContext(testUri);
 
-            expect(MockedFileContext).toHaveBeenCalledWith(testUri, DocumentType.YAML, '');
-            expect(result).toBe(mockFileContext);
+            expect(MockedFileContext).not.toHaveBeenCalled();
+            expect(result).toBeUndefined();
         });
 
         it('should handle complex CloudFormation templates', () => {
@@ -263,12 +261,11 @@ Outputs:
 
             mockDocumentManager.get.returns(mockDocument as any);
             mockDocumentManager.isTemplate.returns(true);
-            MockedFileContext.mockImplementation(() => ({}) as FileContext);
 
             const result = fileContextManager.getFileContext(testUri);
 
-            expect(MockedFileContext).toHaveBeenCalledWith(testUri, DocumentType.YAML, undefined);
-            expect(result).toBeDefined();
+            expect(MockedFileContext).not.toHaveBeenCalled();
+            expect(result).toBeUndefined();
         });
 
         it('should handle DocumentManager throwing errors', () => {
diff --git a/tst/utils/TemplateBuilder.ts b/tst/utils/TemplateBuilder.ts
@@ -204,7 +204,12 @@ export class TemplateBuilder {
 
         // Create syntax tree using proper document detection (like real LSP)
         const document = createDocument(textDocument);
-        this.syntaxTreeManager.addWithTypes(this.uri, document.contents(), document.documentType, document.cfnFileType);
+        this.syntaxTreeManager.addWithTypes(
+            this.uri,
+            document.contents() ?? '',
+            document.documentType,
+            document.cfnFileType,
+        );
     }
 
     typeAt(position: Position, text: string): void {

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ export class ManagedResourceCodeLens {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`const text = document.getText();`
	`31`	`+ if (!text) {`
	`32`	`+ return [];`
	`33`	`+ }`
`31`	`34`	`const lines = text.split('\n');`
`32`	`35`
`33`	`36`	`for (const [, resourceContext] of resourcesMap) {`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,10 @@ export class DocumentManager implements SettingsConfigurable, Closeable {`
`176`	`176`	`private emitDocSizeMetrics() {`
`177`	`177`	`for (const doc of this.documentMap.values()) {`
`178`	`178`	`if (doc.isTemplate()) {`
`179`		`- this.telemetry.histogram('documents.template.size.bytes', byteSize(doc.contents()), { unit: 'By' });`
	`179`	`+ const content = doc.contents();`
	`180`	`+ if (content) {`
	`181`	`+ this.telemetry.histogram('documents.template.size.bytes', byteSize(content), { unit: 'By' });`
	`182`	`+ }`
`180`	`183`	`}`
`181`	`184`	`}`
`182`	`185`	`}`