Skip to content

[Regression] Too few arguments to function field_ui_admin_access() #7045

@bugfolder

Description

@bugfolder

Description of the bug

After updating from 1.32.0 to 1.33.x-dev and visiting the admin/reports/status page, site crashes with "Too few arguments to function field_ui_admin_access()"

Steps To Reproduce

To reproduce the behavior, you need a site running 1.32.x to upgrade:

  1. Log into the site as an admininstrator.
  2. Replace the 1.32.x code with 1.33.x (e.g., via ftp or copying in locally).
  3. Visit admin/reports/status. Crash happens. Reloading that page will still crash.

One can also reproduce it on a dev site with github access if you have bee working. Again, be logged in as an admin.

  1. Check out 1.32.x.
  2. bee cc all to clear all caches and reset things (mostly) to 1.32.x state.
  3. Check out 1.33.x-dev.
  4. Visit admin/reports/status. See crash.
  5. bee cc then 5 (menu) to clear the menu cache.
  6. Reload admin/reports/status. Success.

Expected behavior

No crash.

Additional information

This is due to changes in Add option to globally disable comments on a content type. · Issue #3016 · backdrop/backdrop-issues. The problem seems to be that when field_ui_admin_access was changed to take 4 arguments, the menu cache still only passes 2 arguments until the menu cache is cleared.

More discussion at https://backdrop.zulipchat.com/#narrow/channel/218635-Backdrop/topic/Too.20few.20arguments.20to.20function.20field_ui_admin_access.28.29/with/566473064.

Even if the crash happens and no ordinary pages respond, running update.php clears the menu cache and fixes the problem.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions