fix: lint (#438)

* fix(lint): up-to-date lint

Signed-off-by: ismael FALL <[email protected]>

* fix(lint): update go version ci tests

Signed-off-by: ismael FALL <[email protected]>

* fix(lint): update go version ci tests on all os

Signed-off-by: ismael FALL <[email protected]>

* chore: update .github/workflows/ci.yml

Signed-off-by: ismael FALL <[email protected]>
Co-authored-by: Manfred Touron <[email protected]>

Author: Doozers

.github/workflows/ci.yml

@@ -23,15 +23,15 @@ jobs:
         uses: golangci/golangci-lint-action@v2
         with:
           args: --timeout=10m
-          version: v1.28
+          version: v1.49
           github-token: ${{ secrets.GITHUB_TOKEN }}
   tests-on-windows:
     needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
     runs-on: windows-latest
     strategy:
       matrix:
         golang:
-          - 1.15.x
+          - 1.18.x
     steps:
       - uses: actions/checkout@v2
       - name: Install Go
@@ -47,7 +47,7 @@ jobs:
     strategy:
       matrix:
         golang:
-          - 1.15.x
+          - 1.18.x
     steps:
       - uses: actions/checkout@v2
       - name: Install Go
@@ -68,8 +68,8 @@ jobs:
     strategy:
       matrix:
         golang:
-          - 1.14.x
-          - 1.15.x
+          - 1.18.x
+          - 1.19.x
     steps:
       - uses: actions/checkout@v2
       - name: Install Go

go.mod

@@ -170,7 +170,7 @@ func yolo(args []string) error {
 			}
 
 			if artifactsCachePath != "" {
-				if err := os.MkdirAll(artifactsCachePath, 0755); err != nil {
+				if err := os.MkdirAll(artifactsCachePath, 0o755); err != nil {
 					return err
 				}
 			}

go/cmd/yolo/main.go

@@ -25,7 +25,6 @@ func (b *Build) PrepareOutput(salt string) error {
 
 // AddSignedURLs adds new fields containing URLs with a signature
 func (a *Artifact) AddSignedURLs(key string) error {
-
 	var err error
 	a.DLArtifactSignedURL, err = signature.GetSignedURL("GET", "/api/artifact-dl/"+a.ID, "", key)
 	if err != nil {

go/pkg/yolopb/types.go

@@ -5,9 +5,7 @@ import (
 	"strings"
 )
 
-var (
-	signedOffByLine = regexp.MustCompile(`Signed-off-by: (.*)`)
-)
+var signedOffByLine = regexp.MustCompile(`Signed-off-by: (.*)`)
 
 func cleanupCommitMessage(msg string) string {
 	if msg == "" {

go/pkg/yolopb/util.go

@@ -9,7 +9,6 @@ import (
 )
 
 type Store interface {
-
 	// artifacts store
 	GetArtifactByID(id string) (*yolopb.Artifact, error)
 	GetAllArtifactsWithoutBundleID() ([]*yolopb.Artifact, error)

go/pkg/yolostore/store.go

@@ -120,7 +120,6 @@ func TestServiceDevDumpObjects(t *testing.T) {
 
 	assert.Equal(t, expectedDownloads, resp.Downloads)
 	assert.Equal(t, expectedBatch, resp.Batch)
-
 }
 
 func TestServiceDevDumpObjects_withPreloading(t *testing.T) {
@@ -244,5 +243,4 @@ func TestServiceDevDumpObjects_withPreloading(t *testing.T) {
 
 	assert.Equal(t, expectedDownloads, resp.Downloads)
 	assert.Equal(t, expectedBatch, resp.Batch)
-
 }

go/pkg/yolosvc/api_dev_test.go

@@ -6,7 +6,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"net/http"
 	"net/url"
 	"os"
@@ -26,7 +25,6 @@ import (
 )
 
 func (svc *service) ArtifactDownloader(w http.ResponseWriter, r *http.Request) {
-
 	id := chi.URLParam(r, "artifactID")
 
 	artifact, err := svc.store.GetArtifactByID(id)
@@ -200,7 +198,7 @@ func (svc *service) signAndStreamIPA(artifact yolopb.Artifact, w io.Writer) erro
 	// sign ipa
 	var signed string
 	{
-		tempdir, err := ioutil.TempDir("", "yolo")
+		tempdir, err := os.MkdirTemp("", "yolo")
 		if err != nil {
 			return err
 		}
@@ -209,7 +207,7 @@ func (svc *service) signAndStreamIPA(artifact yolopb.Artifact, w io.Writer) erro
 		// write unsigned-file to tempdir
 		unsigned := filepath.Join(tempdir, "unsigned.ipa")
 		signed = filepath.Join(tempdir, "signed.ipa")
-		f, err := os.OpenFile(unsigned, os.O_RDWR|os.O_CREATE, 0755)
+		f, err := os.OpenFile(unsigned, os.O_RDWR|os.O_CREATE, 0o755)
 		if err != nil {
 			return err
 		}
@@ -308,7 +306,7 @@ func (svc *service) artifactDownloadFromProvider(artifact *yolopb.Artifact, w io
 				return fmt.Errorf("failed to download artifact: %w", err)
 			}
 			defer resp.Body.Close()
-			zipContent, err = ioutil.ReadAll(resp.Body)
+			zipContent, err = io.ReadAll(resp.Body)
 			if err != nil {
 				return fmt.Errorf("failed to download artifact stream: %w", err)
 			}

go/pkg/yolosvc/api_download.go

@@ -9,6 +9,8 @@ import (
 	"berty.tech/yolo/v2/go/pkg/plistgen"
 	"github.com/go-chi/chi"
 	"github.com/stretchr/signature"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 	"google.golang.org/grpc/codes"
 )
 
@@ -36,9 +38,10 @@ func (svc *service) PlistGenerator(w http.ResponseWriter, r *http.Request) {
 		url           = "/api/artifact-dl/" + id
 	)
 	if artifact.HasBuild != nil && artifact.HasBuild.HasProject != nil {
-		title = strings.Title(artifact.HasBuild.HasProject.Name)
+		c := cases.Title(language.Und)
+		title = c.String(artifact.HasBuild.HasProject.Name)
 		if artifact.HasBuild.HasProject.HasOwner != nil {
-			subtitle = strings.Title(artifact.HasBuild.HasProject.HasOwner.Name)
+			subtitle = c.String(artifact.HasBuild.HasProject.HasOwner.Name)
 		}
 	}
 	pkgURL, err := signature.GetSignedURL("GET", url, "", svc.authSalt)

go/pkg/yolosvc/api_plist.go

@@ -23,7 +23,7 @@ type BintrayWorkerOpts struct {
 func (svc *service) BintrayWorker(ctx context.Context, opts BintrayWorkerOpts) error {
 	opts.applyDefaults()
 
-	var logger = opts.Logger.Named("btry")
+	logger := opts.Logger.Named("btry")
 
 	for iteration := 0; ; iteration++ {
 		logger.Debug("bintray: refresh", zap.Int("iteration", iteration))