W39 Lib Team Call

[nondiremanuel]

📆 Tues September 26, 2023 12:00 UTC
📍 Discord General Voice Channel

Meeting Notes:

Please add comments to this issue to suggest issues and PRs to discuss.

General Discussion Items

• BDK 1.0 milestones and timeline
  Possible new timeline: 1.0 beta release ready for the end of 2023.
  Highest priorities on alpha.2 milestone: review (and possible takeover) on Better tests for transaction conflict handling bdk#1064 and work/review on Add bitcoind_rpc chain source module. bdk#1041
  General need of rebase for some PRs in alpha.2
  We tried to define during this call the (hopefully) final scope of alpha.3 release: BDK Wallet (view)
• BDK Review Club
• Any review begs? 🙏
• Blockers? 🪨

New Projects and Support

• feat: add bdk_sqlite crate implementing PersistBackend bdk#1128: which version/milestone? @notmandatory -> needed for the bindings, alpha.3
• ci: Check commits in PRs bdk#1122
• Way too many clippy::allow bdk#1127
• Remove TxGraph::missing_heights as ChangeSet::missing_heights_from should have replaced it bdk#1126
• wallet_esplora_async returns error 429 while scanning bdk#1120 -> endpoint specific (public node, so nice to have)
• feat: add dependabot bdk#1121 and CI: Enforce conventional commits and signed commits bdk_wallet#135 on CI

Top BDK 1.0 PRs and issues

alpha.2

Recently merged:

• Enhance bdk chain structures bdk#1084
• Rename methods of esplora ext bdk#1070
• Update documentation for fee_rate and fee_absolute methods in tx_builder.rs bdk#969

Ready to be merged:

Changes requested:

• Better tests for transaction conflict handling bdk#1064 : changes requested by LLFourn -> if LaggingTimes can't work on it, it will probably need to be taken over since it is top priority

Need Review:

• Test status of reorg tx bdk#1124: examples for Add bitcoind_rpc chain source module. bdk#1041
• fix(esplora): use saturating_add in update_tx_graph() bdk#1110: ready to be merged or needs other reviews? -> ready to be merged

In progress:

• Add bitcoind_rpc chain source module. bdk#1041: is it ready to review after the last changes? @evanlinjin -> needs some more changes, evan working on it. Top priority

To Do:

• Calling example_electrum sync on an unconfirmed tx may result in the tx being stuck as unconfirmed eternally (according to the cli)) bdk#1125: new bug; needed for alpha.2 or can we postpone it? -> moved to alpha.3

alpha.3

Recently merged:

• docs: fix spelling errors bdk#1086

Ready to be merged:

Changes requested:

Need Review:

In progress:

• Add CreateTxError and use as error type for TxBuilder::finish() bdk#1028: needs to be rebased after alpha.2 milestone
• fix: remove deprecated max_satisfaction_weight bdk#1115: still in progress or needs review? @realeinherjar -> on hold, needs some comment from evan and/or Lloyd

To Do:

• Create LocalChain with genesis block hardwired for Network bdk#1079: Lloyd needs some clarification on the API -> keep for the moment, nice security feature
• test: consolidate esplora blocking and async test code bdk#2098 -> pretty simple change
• Add integration tests for electrum, esplora, bitcoind_rpc crates bdk#1094: to be done after test: consolidate esplora blocking and async test code bdk#2098 -> if we run out of time we will move it to the Beta milestone
• Inconsistent checking of RBF rules bdk_wallet#192 -> probably an old question, closed
• Reintroduce descriptor data to bdk::Wallet persistence bdk#1101 -> ongoing discussion, good to keep in alpha.3
• bdk::Wallet should have context-specific error types bdk#994 -> fixed by Add CreateTxError and use as error type for TxBuilder::finish() bdk#1028 (in progress)
• The Wallet.is_mine() function should return K bdk#1042 -> keep it in alpha.3

Milestone TBD:

• BlockId should not have a default and passing a chain tip should be an Option #1107  bdk#1116 -> needs some rebasing but mostly done, moved to alpha.3
• test: legacy descriptors bdk#1130
• Add legacy wallet tests bdk_wallet#134
• Test blockchain backend bdk_wallet#185 -> moved to beta for the moment
• Document example code or add helper code for fee estimation bdk_wallet#140 -> to Beta since we need to provide documentation
• rename scan to scan_with_keychain bdk#1117: in progress to fix scan_without_keychain and scan's names should be inverted bdk#1112 To be confirmed whether it's in milestone 2 -> moved to alpha.3
• Add RPC Wallet Example bdk#1106 -> linked to the Add bitcoind_rpc chain source module. bdk#1041, moved to alpha.3
• Refactor TxGraph::walk_conflicts to check for ancestors bdk_wallet#136 -> discussion still ongoing, moved to 1.1
• Further improve unconfirmed tx conflict resolution bdk#1109: Better tests for transaction conflict handling bdk#1064 may need to be merged first -> moved to alpha.3

Top Maintenance PRs and issues

• Support addr() descriptors bdk_wallet#174

Upcoming Events

• BTC Azores Sept 23-24
• PlanB Lugano Oct 20-21

🌅 Future Call Notes

📜 Past Call Notes