Modern exit codes - which returned if multiple warnings/errors?

[WilliamDEdwards]

When using modern exit codes (BORG_EXIT_CODES=modern), borg create returns exit codes corresponding to a (meaningful) message ID.

I would like to use these to ignore FileChangedWarning, but I'm wondering: what code is returned when multiple warnings/errors are reported? Say a command returns a FileChangedWarning and a BorgWarning, is the highest-severity ('worst') one returned, the first, or something else?

I looked in https://github.com/borgbackup/borg/blob/master/src/borg/archiver/create_cmd.py, but that code is a bit too abstracted for me to understand.

[PhrozenByte]

AFAIK: Borg classifies exit codes into signal (rc 128-255), error (rc 2, or 3-99), warning (rc 1, or 100-127), and success (rc 0) groups. Groups take precedence in that order (i.e., if Borg terminates due to a signal, it strictly exits with the matching rc). Multiple termination signals / errors shouldn't be possible, but if they occur for whatever reason, the first one takes precedence. Warnings are a different story: If there was just one warning, Borg exits with the rc matching that warning. If there were multiple warnings, Borg exits with rc 1 (i.e., the generic warning rc). All individual warnings are still logged though.

I guess we could improve the docs in this regard. It currently only says "operation reached its normal end, but there were warnings", which kinda hints that, but definitely is no clear answer to the question.

[ThomasWaldmann]

@WilliamDEdwards The code you linked is from master branch (borg2), the 1.4.x code is in 1.4-maint branch.

[WilliamDEdwards]

@PhrozenByte @ThomasWaldmann Thanks guys and/or girls and/or earthlings! The docs could definitely use an update in this regard.

To clarify: if there were warnings and an error, do I understand correctly that (due to the precedence of groups) the process would exit with the error RC?

[ThomasWaldmann]

Yes, borg always reports the most severe issue. errors > warnings.

Also, such errors are usually immediately fatal, while warnings (often relating to a specific file) make borg skip that file and continue.

[PhrozenByte]

See #9945 for master, manual backport to 1.4-maint required due to the different BORG_EXIT_CODES default.