fix: extension fails to load with node 24

fixes #77

Signed-off-by: Gordon Smith <[email protected]>

Author: GordonSmith

.github/workflows/ci.yml

@@ -7,62 +7,68 @@ on:
     branches: [main]
 
 jobs:
-  build:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      issues: write
-      pull-requests: write
-    steps:
-      - uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: "22"
+    build:
+      strategy:
+        fail-fast: false
+        matrix:
+          os: [ubuntu-latest, windows-latest, macos-latest]
+          node-version: [20, 22, 24]
+      runs-on: ${{ matrix.os }}
+      permissions:
+        contents: read
+        issues: write
+        pull-requests: write
+      steps:
+        - uses: actions/checkout@v4
 
-      - name: Install dependencies
-        run: npm ci
+        - uses: actions/setup-node@v3
+          with:
+            node-version: ${{ matrix.node-version }}
 
-      - name: Run tests
-        run: npm test
+        - name: Install dependencies
+          run: npm ci
 
-      - name: Update snapshot
-        run: npm run update-snapshot && git add --all
+        - name: Run tests
+          run: npm test
 
-      - name: Prepare diff for comment
-        id: diff
-        continue-on-error: true
-        run: |
-          set +e
-          body=$(git diff --exit-code --diff-filter=AM $GITHUB_SHA -- '*.snap' 2>&1)
-          echo "exitcode=$?" >> $GITHUB_OUTPUT
-          body="${body//'<'/'&lt;'}"
-          body="${body//'>'/'&gt;'}"
-          delimiter="$(openssl rand -hex 8)"
-          echo "body<<${delimiter}" >> $GITHUB_OUTPUT
-          echo "${body:0:64000}" >> $GITHUB_OUTPUT
-          echo "${delimiter}" >> $GITHUB_OUTPUT
+        - name: Update snapshot
+          run: npm run update-snapshot && git add --all
 
-      - uses: marocchino/sticky-pull-request-comment@v2
-        if: github.event_name == 'pull_request' && steps.diff.outputs.exitcode == '1'
-        with:
-          header: sticky-comment-for-git-diff
-          hide_and_recreate: true
-          hide_classify: "OUTDATED"
-          message: |
-            **Found changes in the snapshot tests. Please review.**
-            <details>
-            <summary>Diff 📖</summary>
+        - name: Prepare diff for comment
+          id: diff
+          continue-on-error: true
+          run: |
+            set +e
+            body=$(git diff --exit-code --diff-filter=AM $GITHUB_SHA -- '*.snap' 2>&1)
+            echo "exitcode=$?" >> $GITHUB_OUTPUT
+            body="${body//'<'/'&lt;'}"
+            body="${body//'>'/'&gt;'}"
+            delimiter="$(openssl rand -hex 8)"
+            echo "body<<${delimiter}" >> $GITHUB_OUTPUT
+            echo "${body:0:64000}" >> $GITHUB_OUTPUT
+            echo "${delimiter}" >> $GITHUB_OUTPUT
 
-            <pre lang="diff"><code>
-            ${{ steps.diff.outputs.body }}
-            </code></pre>
+        - uses: marocchino/sticky-pull-request-comment@v2
+          if: github.event_name == 'pull_request' && steps.diff.outputs.exitcode == '1'
+          with:
+            header: sticky-comment-for-git-diff
+            hide_and_recreate: true
+            hide_classify: "OUTDATED"
+            message: |
+              **Found changes in the snapshot tests. Please review.**
+              <details>
+              <summary>Diff 📖</summary>
 
-            </details>
+              <pre lang="diff"><code>
+              ${{ steps.diff.outputs.body }}
+              </code></pre>
 
-      - uses: marocchino/sticky-pull-request-comment@v2
-        if: github.event_name == 'pull_request' && steps.diff.outputs.exitcode == '0'
-        with:
-          header: sticky-comment-for-git-diff
-          hide: true
-          hide_classify: "OUTDATED"
+              </details>
+
+        - uses: marocchino/sticky-pull-request-comment@v2
+          if: github.event_name == 'pull_request' && steps.diff.outputs.exitcode == '0'
+          with:
+            header: sticky-comment-for-git-diff
+            hide: true
+            hide_classify: "OUTDATED"

esbuild.mjs

@@ -655,7 +655,6 @@ async function discoverEntryPoints() {
             external: ["vscode"],
             write: false, // Don't write to disk
             logLevel: "silent",
-            inject: ["src/node-polyfills.js"],
         });
 
         if (tempResult.outputFiles && tempResult.outputFiles.length > 0) {
@@ -721,7 +720,6 @@ async function main() {
             external: ["vscode"],
             logLevel: "silent",
             plugins: [resourceDiscoveryPlugin, wasmDiscoveryPlugin],
-            inject: ["src/node-polyfills.js"],
             define: {
                 // Define globals to prevent bundling issues
                 "process.env.NODE_ENV": JSON.stringify(production ? "production" : "development"),

package.json

@@ -28,8 +28,8 @@
         "clean-full": "npm run clean-all && npm run clean-deps",
         "setup-wasm": "./scripts/setup-wasm.sh",
         "install-extension": "npm run package && code --install-extension wit-idl.vsix",
-        "update-snapshot": "vscode-tmgrammar-snap --updateSnapshot --scope 'source.wit' 'tests/grammar/integration/*'",
-        "test-grammar": "vscode-tmgrammar-test -c --grammar syntaxes/wit.tmLanguage.json 'tests/grammar/unit/*'",
+        "update-snapshot": "vscode-tmgrammar-snap --updateSnapshot --scope \"source.wit\" \"tests/grammar/integration/*\"",
+        "test-grammar": "vscode-tmgrammar-test -c --grammar syntaxes/wit.tmLanguage.json \"tests/grammar/unit/*\"",
         "test-unit": "vitest run",
         "test-unit-watch": "vitest",
         "test-unit-ui": "vitest --ui",