feat: add types for req.req and req.res

[schwma]

part of cap/issues/17887
documented in capire/docs#1603

[daogrady]

From what I can see, this looks pretty much done. Is it still a draft or ready for review?

[schwma]

The PR is still a draft since the API isn't final yet and might still change. See capire/docs#1603 (comment) for slightly more details.

[daogrady]

I see! Just wanted to make sure you were not waiting for my approval. 🙂

[schwma]

Thank you! 🙂 I'll let you know as soon as I know more

[daogrady]

@schwma is the respective runtime change relevant for cds8, or is it only available starting with cds9?

[schwma]

@schwma is the respective runtime change relevant for cds8, or is it only available starting with cds9?

The API is also relevant for cds8, however, as far as I am aware, the API is still not final yet.

[daogrady]

@schwma with cds9 being released, is this now official? If not, is it maybe something we could release with @beta annotation?

[schwma]

@daogrady the API is still not final. I brought this up in our team again today and we decided that it should not yet be released, even with an @beta annotation.

[daogrady]

@schwma with cds10 around the corner, I'd like to put a lid on this PR originally intended for cds9. 😉
Has the API reached its final stage? If yes, we should get this PR merged. If it has not been after over a year, I'd opt to close the PR.

[niklasvieth]

I think they are officially now accessible via req.http https://cap.cloud.sap/docs/node.js/events#http

[daogrady]

Hi Niklas,

thanks for weighing in on this! It does look like it is official now. But, as you noticed, it appears to require another .http in between. @schwma if you'd like to add that in, we can get this merged today and shipped with the next release of cds-types.

Best,
Daniel

[schwma]

Hi all, thanks for the heads up! Types for req.http.req/res already exist here:

cds-types/apis/events.d.ts

Line 15 in 662aeb7

http?: { req: express.Request, res: express.Response }

This PR is specifically about req.req/res. @daogrady after laying dormant for a while, the larger overarching topic (which this PR is a part of) is once again an active work in progress in our team. I will update the PR once everything has been finalized.