"Unpublished" migration can lead to inconsistent state between devices

[Hocuri]

When updating to v2.46.0 or newer, the migration sets all relays but the primary one as unpublished.

If a second device is already updated and the relays there are "published", then this will lead to inconsistent state: The newly-updated device will have only the primary relay published, the secondary relay

The solution is to call send_sync_transports() after migrating.

@link2xt you said that you don't like the "high-level" migrations; how should we do this code-wise?

[link2xt]

You can set some config like should_send_sync_transports in a migration, then do send_sync_transports() in the inbox loop if the config is set, and reset the config. Just don't call send_sync_transports() from the migration itself.

The reason for this is that if send_sync_transports() later expects different database schema and you put a call to it in a migration, it will start failing and users will not be able to upgrade from old version that is before the migration to the latest one which e.g. adds a new column used by send_sync_transports() (like a recently added is_published).