@@ -18,13 +18,13 @@ package coreweave
1818
1919import (
2020 "fmt"
21+ "sync"
2122
2223 apiv1 "k8s.io/api/core/v1"
2324 "k8s.io/autoscaler/cluster-autoscaler/cloudprovider"
2425 "k8s.io/autoscaler/cluster-autoscaler/config"
2526 "k8s.io/autoscaler/cluster-autoscaler/simulator/framework"
2627 "k8s.io/klog/v2"
27- "sync"
2828)
2929
3030// CoreWeaveNodeGroup represents a node group in the CoreWeave cloud provider.
@@ -85,12 +85,6 @@ func (ng *CoreWeaveNodeGroup) DeleteNodes(nodes []*apiv1.Node) error {
8585 return fmt .Errorf ("some nodes do not belong to node group %s: %v" , ng .Name , err )
8686 }
8787 // If we reach here, it means we can delete the nodes
88- for _ , node := range nodes {
89- // Mark the node for removal
90- if err := ng .nodepool .MarkNodeForRemoval (node ); err != nil {
91- return fmt .Errorf ("failed to mark node %s for removal: %v" , node .Name , err )
92- }
93- }
9488 //update target size
9589 if err := ng .nodepool .SetSize (ng .nodepool .GetTargetSize () - len (nodes )); err != nil {
9690 return fmt .Errorf ("failed to update target size after marking nodes for removal: %v" , err )
@@ -107,6 +101,9 @@ func (ng *CoreWeaveNodeGroup) ForceDeleteNodes(nodes []*apiv1.Node) error {
107101// DecreaseTargetSize decreases the target size of the node group by the specified delta.
108102func (ng * CoreWeaveNodeGroup ) DecreaseTargetSize (delta int ) error {
109103 klog .V (4 ).Infof ("Decreasing target size of node group %s by %d" , ng .Name , delta )
104+ if delta < 0 {
105+ delta = - delta
106+ }
110107 return ng .nodepool .SetSize (ng .nodepool .GetTargetSize () - delta )
111108}
112109
0 commit comments