Wouldn't it be better to split two targets onto two different drivers?
- I don't think that amount of
if checks (we have now in the code) is better than possible code duplication.
sessionStorage and localStorage have different level of support among browsers.
So library can work with one and not work with another. Changing driver factory implies this more than
changing key.- "Controlling argument" is kinda of bad programming style.
- CycleJS driver is about side effect type. LocalStorage and SessionStorage are two different targets. They may have considerably different implementation, performance characteristics, etc.
Two drivers better describe what goes on in reality.
Wouldn't it be better to split two targets onto two different drivers?
ifchecks (we have now in the code) is better than possible code duplication.sessionStorageandlocalStoragehave different level of support among browsers.So library can work with one and not work with another. Changing driver factory implies this more than
changing key.
Two drivers better describe what goes on in reality.