Fix handle spaces in the path to the cl.exe compiler

When the Visual Studio C++ compiler (cl.exe) is installed in a path
containing spaces (e.g., the default "C:\Program Files\Microsoft Visual
Studio\2022\..."), the build system failed to execute it correctly.

The command was invoked without proper quoting, leading to an error:
  'C:\Program' is not recognized as an internal or external command

This commit ensures that the path to cl.exe is properly quoted when
invoking the compiler, allowing builds to succeed on systems with a
standard Visual Studio installation.

Author: dongfengweixiao

pkgs/native_toolchain_c/lib/src/cbuilder/cbuilder.dart

@@ -79,6 +79,7 @@ class CBuilder extends CTool implements Builder {
     super.linkModePreference,
     super.optimizationLevel = OptimizationLevel.o3,
     this.buildMode = BuildMode.release,
+    super.runInShell = false,
   }) : super(type: OutputType.library);
 
   CBuilder.executable({
@@ -105,6 +106,7 @@ class CBuilder extends CTool implements Builder {
     super.cppLinkStdLib,
     super.optimizationLevel = OptimizationLevel.o3,
     this.buildMode = BuildMode.release,
+    super.runInShell = false,
   }) : super(
          type: OutputType.executable,
          assetName: null,
@@ -203,6 +205,7 @@ class CBuilder extends CTool implements Builder {
       language: language,
       cppLinkStdLib: cppLinkStdLib,
       optimizationLevel: optimizationLevel,
+      runInShell: runInShell,
     );
     await task.run();
 

pkgs/native_toolchain_c/lib/src/cbuilder/clinker.dart

@@ -41,6 +41,7 @@ class CLinker extends CTool implements Linker {
     super.cppLinkStdLib,
     super.linkModePreference,
     super.optimizationLevel = OptimizationLevel.o3,
+    super.runInShell = false,
   }) : super(type: OutputType.library);
 
   /// Runs the C Linker with on this C build spec.
@@ -94,6 +95,7 @@ class CLinker extends CTool implements Linker {
       language: language,
       cppLinkStdLib: cppLinkStdLib,
       optimizationLevel: optimizationLevel,
+      runInShell: runInShell,
     );
     await task.run();
 

pkgs/native_toolchain_c/lib/src/cbuilder/ctool.dart

@@ -166,6 +166,12 @@ abstract class CTool {
   /// What optimization level should be used for compiling.
   final OptimizationLevel optimizationLevel;
 
+  /// Whether to run the compiler/linker in a shell.
+  ///
+  /// If the cl.exe path contains spaces, this parameter needs to be set to
+  /// false.
+  final bool runInShell;
+
   CTool({
     required this.name,
     required this.packageName,
@@ -186,5 +192,6 @@ abstract class CTool {
     required this.linkModePreference,
     required this.type,
     required this.optimizationLevel,
+    required this.runInShell,
   });
 }

pkgs/native_toolchain_c/lib/src/cbuilder/run_cbuilder.dart

@@ -50,6 +50,7 @@ class RunCBuilder {
   final Language language;
   final String? cppLinkStdLib;
   final OptimizationLevel optimizationLevel;
+  final bool runInShell;
 
   RunCBuilder({
     required this.input,
@@ -73,6 +74,7 @@ class RunCBuilder {
     this.language = Language.c,
     this.cppLinkStdLib,
     required this.optimizationLevel,
+    this.runInShell = false,
   }) : outDir = input.outputDirectory,
        assert(
          [executable, dynamicLibrary, staticLibrary].whereType<Uri>().length ==
@@ -120,16 +122,19 @@ class RunCBuilder {
     final toolInstance_ = await compiler();
     final tool = toolInstance_.tool;
     if (tool.isClangLike || tool.isLdLike) {
-      await runClangLike(tool: toolInstance_);
+      await runClangLike(tool: toolInstance_, runInShell: runInShell);
       return;
     } else if (tool == cl) {
-      await runCl(tool: toolInstance_);
+      await runCl(tool: toolInstance_, runInShell: runInShell);
     } else {
       throw UnimplementedError('This package does not know how to run $tool.');
     }
   }
 
-  Future<void> runClangLike({required ToolInstance tool}) async {
+  Future<void> runClangLike({
+    required ToolInstance tool,
+    bool runInShell = false,
+  }) async {
     // Clang for Windows requires the MSVC Developer Environment.
     final environment = await _resolver.resolveEnvironment(tool);
 
@@ -182,6 +187,7 @@ class RunCBuilder {
           [sourceFiles[i]],
           objectFile,
           environment,
+          runInShell,
         );
         objectFiles.add(objectFile);
       }
@@ -196,6 +202,7 @@ class RunCBuilder {
         captureOutput: false,
         throwOnUnexpectedExitCode: true,
         environment: environment,
+        runInShell: runInShell,
       );
     } else {
       await _compile(
@@ -208,6 +215,7 @@ class RunCBuilder {
         sourceFiles,
         dynamicLibrary != null ? outDir.resolveUri(dynamicLibrary!) : null,
         environment,
+        runInShell,
       );
     }
   }
@@ -223,6 +231,7 @@ class RunCBuilder {
     Iterable<String> sourceFiles,
     Uri? outFile,
     Map<String, String> environment,
+    bool runInShell,
   ) async {
     await runProcess(
       executable: toolInstance.uri,
@@ -343,10 +352,14 @@ class RunCBuilder {
       logger: logger,
       captureOutput: false,
       throwOnUnexpectedExitCode: true,
+      runInShell: runInShell,
     );
   }
 
-  Future<void> runCl({required ToolInstance tool}) async {
+  Future<void> runCl({
+    required ToolInstance tool,
+    bool runInShell = true,
+  }) async {
     final environment = await _resolver.resolveEnvironment(tool);
 
     final isStaticLib = staticLibrary != null;
@@ -401,6 +414,7 @@ class RunCBuilder {
       captureOutput: false,
       stdoutLogLevel: Level.INFO,
       throwOnUnexpectedExitCode: true,
+      runInShell: runInShell,
     );
 
     if (staticLibrary != null) {
@@ -413,6 +427,7 @@ class RunCBuilder {
         captureOutput: false,
         stdoutLogLevel: Level.INFO,
         throwOnUnexpectedExitCode: true,
+        runInShell: runInShell,
       );
     }
 

pkgs/native_toolchain_c/lib/src/utils/run_process.dart

@@ -22,6 +22,7 @@ Future<RunProcessResult> runProcess({
   Level stdoutLogLevel = Level.FINE,
   int expectedExitCode = 0,
   bool throwOnUnexpectedExitCode = false,
+  bool runInShell = false,
 }) async {
   final printWorkingDir =
       workingDirectory != null && workingDirectory != Directory.current.uri;
@@ -41,7 +42,7 @@ Future<RunProcessResult> runProcess({
     arguments,
     workingDirectory: workingDirectory?.toFilePath(),
     environment: environment,
-    runInShell: Platform.isWindows && workingDirectory != null,
+    runInShell: runInShell,
   );
 
   final stdoutSub = process.stdout.listen((List<int> data) {