Commit 364b366
Reland "[ DDC / CFE ] Add support for allowing imports of unsupported libraries"
This reverts commit c616db3.
Reason for revert: Fix landed downstream in Flutter engine: flutter/flutter#180127
Original change's description:
> Revert "[ DDC / CFE ] Add support for allowing imports of unsupported libraries"
>
> This reverts commit b5e60be.
>
> Reason for revert: broke Flutter web engine tests
>
> Original change's description:
> > [ DDC / CFE ] Add support for allowing imports of unsupported libraries
> >
> > This change adds support for allowing for imports of unsupported
> > platform-specific libraries when the
> > `--include-unsupported-platform-library-stubs` flag is provided to the
> > CFE.
> >
> > This flag sets the `includeUnsupportedPlatformLibraryStubs` property in
> > `TargetFlags`, which `Target`s can use to conditionally return different
> > `DartLibrarySupport` objects with different supported/unsupported
> > library sets.
> >
> > A `checkForUnsupportedDartColonImports` function has been added to
> > `Target` that uses the value of `dartLibrarySupport` to determine if
> > there's any unsupported library imports. This function is called after
> > the various transformation operations provided by the `Target`
> > implementation, meaning the import of an unsupported library specified
> > in `dartLibrarySupport` will now result in a compilation error (this
> > includes `dart:mirrors` imports for VM targets when mirrors are
> > disabled, which was previously handled by the VM itself).
> >
> > Related to #62125
> >
> > TEST=Tests added / modified
> >
> > Change-Id: Ife819b2e1a6d28f67d80aab6701cd23a1724aa4d
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465760
> > Reviewed-by: Nicholas Shahan <[email protected]>
> > Reviewed-by: Johnni Winther <[email protected]>
> > Commit-Queue: Ben Konyi <[email protected]>
>
> Change-Id: I0b59f00e55a2424f783351abd977eb38409ce01f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469100
> Reviewed-by: Nate Biggs <[email protected]>
> Commit-Queue: Alexander Markov <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Ben Konyi <[email protected]>
> Reviewed-by: Sigmund Cherem <[email protected]>
Change-Id: I1ae2eac675432286aebabea3c1f58caf35a27fbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469240
Commit-Queue: Ben Konyi <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>1 parent f380cba commit 364b366
File tree
55 files changed
+833
-147
lines changed- pkg
- dev_compiler
- lib/src/kernel
- test/expression_compiler
- front_end
- lib/src
- base
- builder
- codes
- dill
- kernel
- source
- testcases/general
- patch_internal
- supported_libraries
- test
- static_types
- types
- tool
- frontend_server/lib
- kernel/lib
- src/ast
- target
- testing
- text
- vm
- lib
- testcases/transformations/mixin_deduplication
- sdk/lib
- tests
- co19
- lib/js/static_interop_test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
55 files changed
+833
-147
lines changedLines changed: 109 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
78 | 80 | | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
82 | 104 | | |
83 | 105 | | |
84 | 106 | | |
| |||
314 | 336 | | |
315 | 337 | | |
316 | 338 | | |
317 | | - | |
318 | | - | |
319 | | - | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
320 | 348 | | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
321 | 360 | | |
322 | 361 | | |
323 | 362 | | |
324 | 363 | | |
325 | 364 | | |
326 | 365 | | |
327 | | - | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
328 | 369 | | |
329 | 370 | | |
330 | 371 | | |
| |||
362 | 403 | | |
363 | 404 | | |
364 | 405 | | |
365 | | - | |
366 | | - | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
367 | 411 | | |
368 | 412 | | |
369 | 413 | | |
| |||
372 | 416 | | |
373 | 417 | | |
374 | 418 | | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
375 | 445 | | |
376 | 446 | | |
377 | 447 | | |
| |||
404 | 474 | | |
405 | 475 | | |
406 | 476 | | |
407 | | - | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
408 | 483 | | |
409 | 484 | | |
410 | 485 | | |
411 | 486 | | |
412 | 487 | | |
413 | | - | |
| 488 | + | |
| 489 | + | |
414 | 490 | | |
415 | 491 | | |
416 | 492 | | |
| |||
495 | 571 | | |
496 | 572 | | |
497 | 573 | | |
498 | | - | |
499 | | - | |
500 | | - | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
0 commit comments