Skip to content

Commit 2124270

Browse files
committed
Fix dartpy PYTHONPATH for tests
1 parent 19cc1d7 commit 2124270

File tree

4 files changed

+14
-8
lines changed

4 files changed

+14
-8
lines changed

python/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,12 @@ endif()
3838

3939
set(DART_PYTHON_BUILD_DIR "${CMAKE_CURRENT_BINARY_DIR}")
4040
set(DART_DARTPY_BUILD_DIR "${DART_PYTHON_BUILD_DIR}/dartpy")
41+
if(WIN32)
42+
# Use an escaped separator so the full value is passed as a single argument
43+
set(DART_PYTHONPATH "${DART_DARTPY_BUILD_DIR}\\;${DART_PYTHON_BUILD_DIR}")
44+
else()
45+
set(DART_PYTHONPATH "${DART_DARTPY_BUILD_DIR}:${DART_PYTHON_BUILD_DIR}")
46+
endif()
4147

4248
add_subdirectory(dartpy)
4349
add_subdirectory(tests)

python/examples/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ function(dartpy_add_example example_name) # ARGN for source file
1010
set(source "${example_name}.py")
1111
endif()
1212
add_custom_target(${example_name}
13-
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} ${source}"
14-
COMMAND ${CMAKE_COMMAND} -E env "PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} ${source}"
13+
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHONPATH} ${Python3_EXECUTABLE} ${source}"
14+
COMMAND ${CMAKE_COMMAND} -E env "PYTHONPATH=${DART_PYTHONPATH}" ${Python3_EXECUTABLE} ${source}
1515
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
1616
SOURCES ${source}
1717
)

python/tests/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ file(GLOB_RECURSE dartpy_test_files "test_*.py")
2929
# Add custom target to run the tests
3030
if(DARTPY_PYTEST_FOUND)
3131
add_custom_target(pytest
32-
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} -m pytest [sources]"
33-
COMMAND ${CMAKE_COMMAND} -E env PYTHONPATH="${DART_PYTHON_BUILD_DIR}" "${Python3_EXECUTABLE}" -m pytest ${dartpy_test_files} -v
32+
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHONPATH} ${Python3_EXECUTABLE} -m pytest [sources]"
33+
COMMAND ${CMAKE_COMMAND} -E env "PYTHONPATH=${DART_PYTHONPATH}" "${Python3_EXECUTABLE}" -m pytest ${dartpy_test_files} -v
3434
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
3535
SOURCES ${dartpy_test_files} ${dartpy_test_utils}
3636
DEPENDS dartpy
@@ -53,8 +53,8 @@ function(dartpy_add_test test_name) # ARGN for source file
5353
set(source "${test_name}.py")
5454
endif()
5555
add_custom_target(${test_name}
56-
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} ${source}"
57-
COMMAND ${CMAKE_COMMAND} -E env PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} ${source}
56+
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHONPATH} ${Python3_EXECUTABLE} ${source}"
57+
COMMAND ${CMAKE_COMMAND} -E env "PYTHONPATH=${DART_PYTHONPATH}" ${Python3_EXECUTABLE} ${source}
5858
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
5959
SOURCES ${source}
6060
DEPENDS dartpy

python/tutorials/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ function(dartpy_add_tutorial tutorial_name) # ARGN for source file
1010
set(source "${tutorial_name}.py")
1111
endif()
1212
add_custom_target(${tutorial_name}
13-
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} ${source}"
14-
COMMAND ${CMAKE_COMMAND} -E env PYTHONPATH=${DART_PYTHON_BUILD_DIR} ${Python3_EXECUTABLE} ${source}
13+
COMMAND ${CMAKE_COMMAND} -E echo "Running pytest by: PYTHONPATH=${DART_PYTHONPATH} ${Python3_EXECUTABLE} ${source}"
14+
COMMAND ${CMAKE_COMMAND} -E env "PYTHONPATH=${DART_PYTHONPATH}" ${Python3_EXECUTABLE} ${source}
1515
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
1616
SOURCES ${source}
1717
)

0 commit comments

Comments
 (0)