ai: apply changes for #919 (2 review threads)

Addresses:
  - #3811121476 at src/databricks/sql/backend/kernel/auth_bridge.py:158
  - #3824120741 at tests/unit/test_kernel_auth_bridge.py:36

Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>

Author: peco-engineer-bot[bot]

src/databricks/sql/backend/kernel/auth_bridge.py

@@ -155,7 +155,6 @@ def _extract_bearer_token(auth_provider: Optional[AuthProvider]) -> Optional[str
 def kernel_auth_kwargs(
     auth_provider: Optional[AuthProvider],
     auth_options: Optional[Dict[str, Any]] = None,
-    hostname: Optional[str] = None,
 ) -> Dict[str, Any]:
     """Build the kwargs passed to ``databricks_sql_kernel.Session(...)``.
 

src/databricks/sql/backend/kernel/client.py

@@ -312,7 +312,6 @@ def open_session(
             auth_kwargs = kernel_auth_kwargs(
                 self._auth_provider,
                 self._auth_options,
-                hostname=self._server_hostname,
             )
             # Translate the connector's SSLOptions into the kernel's
             # ``tls_*`` Session kwargs. Empty when TLS is at defaults.

tests/unit/test_kernel_auth_bridge.py

@@ -33,7 +33,6 @@
     PYSQL_OAUTH_SCOPES,
     PYSQL_OAUTH_REDIRECT_PORT_RANGE,
 )
-from databricks.sql.auth.common import get_effective_azure_login_app_id
 from databricks.sql.auth.authenticators import (
     AccessTokenAuthProvider,
     AuthProvider,
@@ -676,7 +675,6 @@ def test_azure_sp_m2m_forwards_creds_to_kernel(self):
         kwargs = kernel_auth_kwargs(
             _FakeOAuthProvider(),
             dict(self._CREDS),
-            hostname="adb-1.azuredatabricks.net",
         )
         # Thin forwarding: the kernel owns endpoint/scope resolution, so no
         # token_url / oauth_scopes are constructed here.
@@ -696,9 +694,7 @@ def test_azure_sp_m2m_tenant_optional_kernel_autodiscovers(self):
             "azure_client_id": "azure-sp",
             "azure_client_secret": "azure-secret",
         }
-        kwargs = kernel_auth_kwargs(
-            _FakeOAuthProvider(), opts, hostname="adb-1.azuredatabricks.net"
-        )
+        kwargs = kernel_auth_kwargs(_FakeOAuthProvider(), opts)
         assert kwargs == {
             "auth_type": "azure-sp-m2m",
             "azure_client_id": "azure-sp",
@@ -714,9 +710,7 @@ def test_azure_sp_m2m_forwards_workspace_resource_id(self):
             self._CREDS,
             azure_workspace_resource_id="/subscriptions/s/resourceGroups/rg/workspace/w",
         )
-        kwargs = kernel_auth_kwargs(
-            _FakeOAuthProvider(), opts, hostname="adb-1.azuredatabricks.net"
-        )
+        kwargs = kernel_auth_kwargs(_FakeOAuthProvider(), opts)
         assert (
             kwargs["azure_workspace_resource_id"]
             == "/subscriptions/s/resourceGroups/rg/workspace/w"
@@ -726,7 +720,6 @@ def test_azure_sp_m2m_omits_workspace_resource_id_when_absent(self):
         kwargs = kernel_auth_kwargs(
             _FakeOAuthProvider(),
             dict(self._CREDS),
-            hostname="adb-1.azuredatabricks.net",
         )
         assert "azure_workspace_resource_id" not in kwargs
 
@@ -735,14 +728,11 @@ def test_azure_sp_m2m_requires_client_id_and_secret(self):
             kernel_auth_kwargs(
                 _FakeOAuthProvider(),
                 {"auth_type": "azure-sp-m2m", "azure_tenant_id": "t"},
-                hostname="adb-1.azuredatabricks.net",
             )
 
     def test_azure_sp_m2m_forwards_federation_client_id(self):
         opts = dict(self._CREDS, identity_federation_client_id="fed-client")
-        kwargs = kernel_auth_kwargs(
-            _FakeOAuthProvider(), opts, hostname="adb-1.azuredatabricks.net"
-        )
+        kwargs = kernel_auth_kwargs(_FakeOAuthProvider(), opts)
         assert kwargs["identity_federation_client_id"] == "fed-client"