Skip to content

Commit e909e75

Browse files
committed
Merge branch 'dev'
2 parents c8fa02f + 10f04ee commit e909e75

File tree

6 files changed

+17
-16
lines changed

6 files changed

+17
-16
lines changed

LyricsX.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1387,23 +1387,23 @@
13871387
repositoryURL = "https://github.com/ddddxxx/SwiftCF.git";
13881388
requirement = {
13891389
kind = upToNextMinorVersion;
1390-
minimumVersion = 0.1.0;
1390+
minimumVersion = 0.1.1;
13911391
};
13921392
};
13931393
BB350ABC23D0613D00500146 /* XCRemoteSwiftPackageReference "CXExtensions" */ = {
13941394
isa = XCRemoteSwiftPackageReference;
13951395
repositoryURL = "https://github.com/cx-org/CXExtensions";
13961396
requirement = {
13971397
kind = upToNextMinorVersion;
1398-
minimumVersion = 0.2.0;
1398+
minimumVersion = 0.2.1;
13991399
};
14001400
};
14011401
BB9C3D8123435A5700860698 /* XCRemoteSwiftPackageReference "MusicPlayer" */ = {
14021402
isa = XCRemoteSwiftPackageReference;
14031403
repositoryURL = "https://github.com/ddddxxx/MusicPlayer";
14041404
requirement = {
14051405
kind = upToNextMinorVersion;
1406-
minimumVersion = 0.6.5;
1406+
minimumVersion = 0.6.7;
14071407
};
14081408
};
14091409
BBB03F2B232FB3AF00A3879E /* XCRemoteSwiftPackageReference "GenericID" */ = {

LyricsX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

LyricsX/Base.lproj/Preferences.storyboard

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,7 @@
295295
</subviews>
296296
<constraints>
297297
<constraint firstItem="5xx-Ht-pau" firstAttribute="top" secondItem="r1e-Ln-LSb" secondAttribute="top" id="0Fe-gL-MER"/>
298+
<constraint firstItem="5xx-Ht-pau" firstAttribute="leading" relation="greaterThanOrEqual" secondItem="r1e-Ln-LSb" secondAttribute="leading" constant="8" id="1Gi-OJ-Aoz"/>
298299
<constraint firstAttribute="bottom" secondItem="5xx-Ht-pau" secondAttribute="bottom" id="MtA-FF-p49"/>
299300
<constraint firstItem="5xx-Ht-pau" firstAttribute="centerX" secondItem="r1e-Ln-LSb" secondAttribute="centerX" id="PDG-4t-SNq"/>
300301
</constraints>

LyricsX/Component/AppController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class AppController: NSObject {
129129
currentLyrics = nil
130130
currentLineIndex = nil
131131
searchCanceller?.cancel()
132-
guard let track = MusicPlayers.Selected.shared.currentTrack else {
132+
guard let track = selectedPlayer.currentTrack else {
133133
return
134134
}
135135
// FIXME: deal with optional value

LyricsX/Supporting Files/Info.plist

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>1.5.2-rc</string>
20+
<string>1.5.2</string>
2121
<key>CFBundleVersion</key>
22-
<string>2263</string>
22+
<string>2271</string>
2323
<key>Fabric</key>
2424
<dict>
2525
<key>APIKey</key>
@@ -43,7 +43,7 @@
4343
<key>LSUIElement</key>
4444
<true/>
4545
<key>LX_BUILD_TIME</key>
46-
<integer>1582947593</integer>
46+
<integer>1584431808</integer>
4747
<key>NSAppTransportSecurity</key>
4848
<dict>
4949
<key>NSExceptionDomains</key>
@@ -128,7 +128,7 @@
128128
</dict>
129129
</dict>
130130
<key>NSAppleEventsUsageDescription</key>
131-
<string>LyricsX needs to know what song you're currently playing, to show lyrics accordingly.</string>
131+
<string>LyricsX needs to know what song you&apos;re currently playing, to show lyrics accordingly.</string>
132132
<key>NSHumanReadableCopyright</key>
133133
<string>Copyright © 2017-2020 Xander Deng. All rights reserved.</string>
134134
<key>NSMainStoryboardFile</key>

LyricsX/View/KaraokeLabel.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class KaraokeLabel: NSTextField {
9494
}
9595
layoutSubtreeIfNeeded()
9696
let progression: CTFrameProgression = isVertical ? .rightToLeft : .topToBottom
97-
let frameAttr: [CTFrame.AttributeKey: Any] = [.progression: progression]
97+
let frameAttr: [CTFrame.AttributeKey: Any] = [.progression: progression.rawValue as NSNumber]
9898
let framesetter = CTFramesetter.create(attributedString: attrString)
9999
let (suggestSize, fitRange) = framesetter.suggestFrameSize(constraints: bounds.size, frameAttributes: frameAttr)
100100
let path = CGPath(rect: CGRect(origin: .zero, size: suggestSize), transform: nil)
@@ -105,7 +105,7 @@ class KaraokeLabel: NSTextField {
105105

106106
override var intrinsicContentSize: NSSize {
107107
let progression: CTFrameProgression = isVertical ? .rightToLeft : .topToBottom
108-
let frameAttr: [CTFrame.AttributeKey: Any] = [.progression: progression]
108+
let frameAttr: [CTFrame.AttributeKey: Any] = [.progression: progression.rawValue as NSNumber]
109109
let framesetter = CTFramesetter.create(attributedString: attrString)
110110
let constraints = CGSize(width: CGFloat.infinity, height: .infinity)
111111
return framesetter.suggestFrameSize(constraints: constraints, frameAttributes: frameAttr).size

0 commit comments

Comments
 (0)