Skip to content

Commit 23a4cd7

Browse files
committed
chore: 프로젝트 형태 삭제로 인한 수정사항 적용
1 parent 7b4af03 commit 23a4cd7

File tree

12 files changed

+13
-54
lines changed

12 files changed

+13
-54
lines changed

layer-api/src/main/java/org/layer/domain/space/controller/dto/SpaceRequest.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,11 @@
22

33
import com.fasterxml.jackson.annotation.JsonInclude;
44
import io.swagger.v3.oas.annotations.media.Schema;
5-
import jakarta.validation.constraints.Min;
65
import jakarta.validation.constraints.NotNull;
7-
import jakarta.validation.constraints.Size;
86

97
import org.layer.annotation.AtLeastNotNull;
108
import org.layer.domain.space.entity.Space;
119
import org.layer.domain.space.entity.SpaceCategory;
12-
import org.layer.domain.space.entity.SpaceField;
13-
14-
import java.util.List;
15-
import java.util.Optional;
1610

1711
@Schema
1812
@JsonInclude(JsonInclude.Include.NON_NULL)
@@ -26,11 +20,6 @@ public record CreateSpaceRequest(
2620
@Schema(description = "프로젝트 유형 카테고리", example = "INDIVIDUAL")
2721
@NotNull
2822
SpaceCategory category,
29-
@Schema(description = "진행중인 프로젝트 유형")
30-
@NotNull
31-
@Size(min = 1)
32-
List<SpaceField> fieldList,
33-
3423
@Schema(description = "이름")
3524
@NotNull
3625
String name,
@@ -41,7 +30,6 @@ public record CreateSpaceRequest(
4130
public Space toEntity(Long memberId) {
4231
return Space.builder()
4332
.category(category)
44-
.fieldList(fieldList)
4533
.name(name)
4634
.introduction(introduction)
4735
.leaderId(memberId)

layer-api/src/main/java/org/layer/domain/space/controller/dto/SpaceResponse.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import org.layer.domain.space.dto.SpaceWithMemberCount;
1313
import org.layer.domain.space.entity.Space;
1414
import org.layer.domain.space.entity.SpaceCategory;
15-
import org.layer.domain.space.entity.SpaceField;
1615

1716
import java.time.LocalDateTime;
1817
import java.util.List;
@@ -29,9 +28,6 @@ public record SpaceWithMemberCountInfo(
2928
@Schema(description = "프로젝트 유형 카테고리")
3029
@NotNull
3130
SpaceCategory category,
32-
@Schema(description = "진행중인 프로젝트 유형")
33-
@NotNull
34-
List<SpaceField> fieldList,
3531
@Schema(description = "이름")
3632
@NotNull
3733
String name,
@@ -57,7 +53,6 @@ public static SpaceWithMemberCountInfo of(Space space, Form form, Long memberCou
5753
return SpaceWithMemberCountInfo.builder()
5854
.id(space.getId())
5955
.category(space.getCategory())
60-
.fieldList(space.getFieldList())
6156
.name(space.getName())
6257
.introduction(space.getIntroduction())
6358
.formId(space.getFormId())
@@ -79,9 +74,6 @@ public record SpaceWithMemberCountAndRetrospectCount(
7974
@Schema(description = "프로젝트 유형 카테고리")
8075
@NotNull
8176
SpaceCategory category,
82-
@Schema(description = "진행중인 프로젝트 유형")
83-
@NotNull
84-
List<SpaceField> fieldList,
8577
@Schema(description = "이름")
8678
@NotNull
8779
String name,
@@ -111,7 +103,6 @@ public static SpaceWithMemberCountAndRetrospectCount toResponse(SpaceWithMemberC
111103
return SpaceWithMemberCountAndRetrospectCount.builder()
112104
.id(space.getId())
113105
.category(space.getCategory())
114-
.fieldList(space.getFieldList())
115106
.name(space.getName())
116107
.introduction(space.getIntroduction())
117108
.formId(space.getFormId())

layer-api/src/main/java/org/layer/domain/space/service/SpaceService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public Long createSpace(Long memberId, SpaceRequest.CreateSpaceRequest createSpa
9595

9696
String bannerUrl = createSpaceRequest.bannerUrl();
9797
if (!storageService.validateBannerUrl(bannerUrl)) {
98-
bannerUrl = storageService.getDefaultBannerUrl(space.getFieldList());
98+
bannerUrl = storageService.getDefaultBannerUrl();
9999
}
100100
space.updateBannerUrl(bannerUrl);
101101

layer-api/src/main/java/org/layer/jwt/JwtAuthenticationFilter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ public class JwtAuthenticationFilter extends OncePerRequestFilter {
2626
protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException {
2727
String accessToken = getJwtFromRequest(request);
2828

29-
3029
if (isValidToken(accessToken)) {
3130
Long memberId = jwtValidator.getMemberIdFromToken(accessToken);
3231
List<String> role = jwtValidator.getRoleFromToken(accessToken);

layer-api/src/test/java/org/layer/domain/fixture/SpaceFixture.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,14 @@
11
package org.layer.domain.fixture;
22

3-
import java.util.List;
4-
53
import org.layer.domain.space.entity.Space;
64
import org.layer.domain.space.entity.SpaceCategory;
7-
import org.layer.domain.space.entity.SpaceField;
85

96
public class SpaceFixture {
107

118
public static Space createFixture(Long leaderId, Long formId){
129
return Space.builder()
1310
.bannerUrl("url1")
1411
.category(SpaceCategory.TEAM)
15-
.fieldList(List.of(SpaceField.DESIGN, SpaceField.DEVELOPMENT))
1612
.name("스페이스 이름1")
1713
.introduction("스페이스 소개1")
1814
.leaderId(leaderId)

layer-api/src/test/java/org/layer/domain/retrospect/service/RetrospectServiceTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.layer.domain.retrospect.service;
22

3-
import static org.layer.domain.space.entity.SpaceField.*;
4-
53
import java.time.LocalDateTime;
64
import java.util.List;
75

layer-api/src/test/java/org/layer/domain/space/SpaceServiceTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.layer.domain.space.entity.MemberSpaceRelation;
2626
import org.layer.domain.space.entity.Space;
2727
import org.layer.domain.space.entity.SpaceCategory;
28-
import org.layer.domain.space.entity.SpaceField;
2928
import org.layer.domain.space.exception.MemberSpaceRelationException;
3029
import org.layer.domain.space.exception.SpaceException;
3130
import org.layer.domain.space.repository.MemberSpaceRelationRepository;
@@ -164,8 +163,7 @@ void createSpaceTest1() {
164163
// given
165164
Long memberId = 1L;
166165
SpaceRequest.CreateSpaceRequest req = new SpaceRequest.CreateSpaceRequest(null,
167-
SpaceCategory.TEAM,
168-
List.of(SpaceField.DESIGN, SpaceField.DEVELOPMENT), "스페이스 이름1", "스페이스 소개1");
166+
SpaceCategory.TEAM,"스페이스 이름1", "스페이스 소개1");
169167

170168
// when
171169
Long spaceId = spaceService.createSpace(memberId, req);
@@ -174,9 +172,8 @@ void createSpaceTest1() {
174172
Space space = spaceRepository.findByIdOrThrow(spaceId);
175173
assertThat(space.getName()).isEqualTo("스페이스 이름1");
176174
assertThat(space.getIntroduction()).isEqualTo("스페이스 소개1");
177-
assertThat(space.getBannerUrl()).containsSubsequence("DESIGN");
175+
assertThat(space.getBannerUrl()).containsSubsequence("EDUCATION");
178176
assertThat(space.getCategory()).isEqualTo(SpaceCategory.TEAM);
179-
assertThat(space.getFieldList()).isEqualTo(List.of(SpaceField.DESIGN, SpaceField.DEVELOPMENT));
180177
}
181178

182179
@Test
@@ -185,8 +182,7 @@ void createSpaceTest2() {
185182
// given
186183
Long memberId = 1L;
187184
SpaceRequest.CreateSpaceRequest req = new SpaceRequest.CreateSpaceRequest("invalid url",
188-
SpaceCategory.TEAM,
189-
List.of(SpaceField.DESIGN, SpaceField.DEVELOPMENT), "스페이스 이름1", "스페이스 소개1");
185+
SpaceCategory.TEAM,"스페이스 이름1", "스페이스 소개1");
190186

191187
// when, then
192188
assertThatThrownBy(() -> spaceService.createSpace(memberId, req));

layer-api/src/test/java/org/layer/domain/space/SpaceServiceWithMockedStorageTest.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,12 @@
44
import static org.mockito.ArgumentMatchers.any;
55
import static org.mockito.Mockito.*;
66

7-
import java.util.List;
8-
97
import org.junit.jupiter.api.DisplayName;
108
import org.junit.jupiter.api.Nested;
119
import org.junit.jupiter.api.Test;
1210
import org.layer.domain.space.controller.dto.SpaceRequest;
1311
import org.layer.domain.space.entity.Space;
1412
import org.layer.domain.space.entity.SpaceCategory;
15-
import org.layer.domain.space.entity.SpaceField;
1613
import org.layer.domain.space.repository.SpaceRepository;
1714
import org.layer.domain.space.service.SpaceService;
1815
import org.layer.storage.service.StorageService;
@@ -44,8 +41,7 @@ void createSpaceTest1() {
4441
// given
4542
Long memberId = 1L;
4643
SpaceRequest.CreateSpaceRequest req = new SpaceRequest.CreateSpaceRequest("new url1",
47-
SpaceCategory.TEAM,
48-
List.of(SpaceField.DESIGN, SpaceField.DEVELOPMENT), "스페이스 이름1", "스페이스 소개1");
44+
SpaceCategory.TEAM,"스페이스 이름1", "스페이스 소개1");
4945

5046
doReturn(true).when(mockStorageService).validateBannerUrl(any());
5147

@@ -58,7 +54,6 @@ void createSpaceTest1() {
5854
assertThat(space.getIntroduction()).isEqualTo("스페이스 소개1");
5955
assertThat(space.getBannerUrl()).isEqualTo("new url1");
6056
assertThat(space.getCategory()).isEqualTo(SpaceCategory.TEAM);
61-
assertThat(space.getFieldList()).isEqualTo(List.of(SpaceField.DESIGN, SpaceField.DEVELOPMENT));
6257
}
6358
}
6459
}

layer-api/src/test/resources/sql/answer-service-test-data.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ VALUES
33
(1, '2024-12-27 00:00:00', '2024-12-27 00:00:00', '[email protected]', 'USER', '홍길동', 'https://example.com/image1.png', 'social_id_1', 'KAKAO', NULL),
44
(2, '2024-12-27 00:00:00', '2024-12-27 00:00:00', '[email protected]', 'USER', '김철수', 'https://example.com/image2.png', 'social_id_2', 'KAKAO', NULL);
55

6-
INSERT INTO space (id, created_at, updated_at, banner_url, category, field_list, form_id, introduction, leader_id, name)
6+
INSERT INTO space (id, created_at, updated_at, banner_url, category, form_id, introduction, leader_id, name)
77
VALUES
8-
(1, '2024-12-27 00:00:00', '2024-12-27 00:00:00', 'https://example.com/banner1.jpg', 'INDIVIDUAL', 'EDUCATION,DEVELOPMENT', NULL, '개인 프로젝트를 위한 공간입니다.', 1, '개인 공간 1');
8+
(1, '2024-12-27 00:00:00', '2024-12-27 00:00:00', 'https://example.com/banner1.jpg', 'INDIVIDUAL', NULL, '개인 프로젝트를 위한 공간입니다.', 1, '개인 공간 1');
99

1010
INSERT INTO member_space_relation (created_at, updated_at, member_id, space_id)
1111
VALUES

layer-domain/src/main/java/org/layer/domain/space/dto/SpaceWithMemberCount.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,8 @@
66
import org.layer.domain.form.enums.FormTag;
77
import org.layer.domain.member.entity.Member;
88
import org.layer.domain.space.entity.SpaceCategory;
9-
import org.layer.domain.space.entity.SpaceField;
109

1110
import java.time.LocalDateTime;
12-
import java.util.List;
13-
1411

1512
@Getter
1613
@Setter
@@ -20,7 +17,6 @@ public class SpaceWithMemberCount {
2017
private LocalDateTime createdAt;
2118
private LocalDateTime updatedAt;
2219
private SpaceCategory category;
23-
private List<SpaceField> fieldList;
2420
private String name;
2521
private String introduction;
2622
private Leader leader;
@@ -30,12 +26,11 @@ public class SpaceWithMemberCount {
3026
private String bannerUrl;
3127

3228
@QueryProjection
33-
public SpaceWithMemberCount(Long id, LocalDateTime createdAt, LocalDateTime updatedAt, SpaceCategory category, List<SpaceField> fieldList, String name, String introduction, Member leader, Long formId, FormTag formTag, Long memberCount, String bannerUrl) {
29+
public SpaceWithMemberCount(Long id, LocalDateTime createdAt, LocalDateTime updatedAt, SpaceCategory category, String name, String introduction, Member leader, Long formId, FormTag formTag, Long memberCount, String bannerUrl) {
3430
this.id = id;
3531
this.createdAt = createdAt;
3632
this.updatedAt = updatedAt;
3733
this.category = category;
38-
this.fieldList = fieldList;
3934
this.name = name;
4035
this.introduction = introduction;
4136
this.leader = leader == null ? null : Leader.builder().id(leader.getId()).name(leader.getName()).build();

0 commit comments

Comments
 (0)