fix time flicker

Author: FDUTCH

server/session/world.go

@@ -2,12 +2,13 @@ package session
 
 import (
 	"fmt"
-	"github.com/df-mc/dragonfly/server/entity/effect"
 	"image/color"
 	"math/rand/v2"
 	"strings"
 	"time"
 
+	"github.com/df-mc/dragonfly/server/entity/effect"
+
 	"github.com/df-mc/dragonfly/server/block"
 	"github.com/df-mc/dragonfly/server/block/cube"
 	"github.com/df-mc/dragonfly/server/entity"
@@ -227,8 +228,9 @@ func entityOffset(e world.Entity) mgl64.Vec3 {
 }
 
 // ViewTime ...
-func (s *Session) ViewTime(time int) {
+func (s *Session) ViewTime(time int, doDayLightCycle bool) {
 	s.writePacket(&packet.SetTime{Time: int32(time)})
+	s.sendGameRules([]protocol.GameRule{{Name: "dodaylightcycle", Value: doDayLightCycle}})
 }
 
 // ViewEntityTeleport ...

server/world/viewer.go

@@ -1,11 +1,12 @@
 package world
 
 import (
+	"time"
+
 	"github.com/df-mc/dragonfly/server/block/cube"
 	"github.com/df-mc/dragonfly/server/world/chunk"
 	"github.com/go-gl/mathgl/mgl64"
 	"github.com/google/uuid"
-	"time"
 )
 
 // Viewer is a viewer in the world. It can view changes that are made in the world, such as the addition of
@@ -38,7 +39,7 @@ type Viewer interface {
 	ViewChunk(pos ChunkPos, dim Dimension, blockEntities map[cube.Pos]Block, c *chunk.Chunk)
 	// ViewTime views the time of the world. It is called every time the time is changed or otherwise every
 	// second.
-	ViewTime(t int)
+	ViewTime(t int, doDayLightCycle bool)
 	// ViewEntityItems views the items currently held by an Entity that is able to equip items.
 	ViewEntityItems(e Entity)
 	// ViewEntityArmour views the items currently equipped as armour by the Entity.
@@ -86,7 +87,7 @@ func (NopViewer) ViewEntityMovement(Entity, mgl64.Vec3, cube.Rotation, bool)
 func (NopViewer) ViewEntityVelocity(Entity, mgl64.Vec3)                                      {}
 func (NopViewer) ViewEntityTeleport(Entity, mgl64.Vec3)                                      {}
 func (NopViewer) ViewChunk(ChunkPos, Dimension, map[cube.Pos]Block, *chunk.Chunk)            {}
-func (NopViewer) ViewTime(int)                                                               {}
+func (NopViewer) ViewTime(int, bool)                                                         {}
 func (NopViewer) ViewEntityItems(Entity)                                                     {}
 func (NopViewer) ViewEntityArmour(Entity)                                                    {}
 func (NopViewer) ViewEntityAction(Entity, EntityAction)                                      {}

server/world/world.go

@@ -4,20 +4,21 @@ import (
 	"encoding/binary"
 	"errors"
 	"fmt"
-	"github.com/df-mc/dragonfly/server/block/cube"
-	"github.com/df-mc/dragonfly/server/event"
-	"github.com/df-mc/dragonfly/server/internal/sliceutil"
-	"github.com/df-mc/dragonfly/server/world/chunk"
-	"github.com/df-mc/goleveldb/leveldb"
-	"github.com/go-gl/mathgl/mgl64"
-	"github.com/google/uuid"
 	"iter"
 	"maps"
 	"math/rand/v2"
 	"slices"
 	"sync"
 	"sync/atomic"
 	"time"
+
+	"github.com/df-mc/dragonfly/server/block/cube"
+	"github.com/df-mc/dragonfly/server/event"
+	"github.com/df-mc/dragonfly/server/internal/sliceutil"
+	"github.com/df-mc/dragonfly/server/world/chunk"
+	"github.com/df-mc/goleveldb/leveldb"
+	"github.com/go-gl/mathgl/mgl64"
+	"github.com/google/uuid"
 )
 
 // World implements a Minecraft world. It manages all aspects of what players
@@ -597,11 +598,12 @@ func (w *World) SetTime(new int) {
 	}
 	w.set.Lock()
 	w.set.Time = int64(new)
+	timeCycle := w.set.TimeCycle
 	w.set.Unlock()
 
 	viewers, _ := w.allViewers()
 	for _, viewer := range viewers {
-		viewer.ViewTime(new)
+		viewer.ViewTime(new, timeCycle)
 	}
 }
 
@@ -619,6 +621,16 @@ func (w *World) StartTime() {
 	w.enableTimeCycle(true)
 }
 
+// TimeCycle returns whether time cycle is enabled.
+func (w *World) TimeCycle() bool {
+	if w == nil {
+		return false
+	}
+	w.set.Lock()
+	defer w.set.Unlock()
+	return w.set.TimeCycle
+}
+
 // enableTimeCycle enables or disables the time cycling of the World.
 func (w *World) enableTimeCycle(v bool) {
 	if w == nil {
@@ -1050,7 +1062,7 @@ func (w *World) addWorldViewer(l *Loader) {
 	w.viewers[l] = l.viewer
 	w.viewerMu.Unlock()
 
-	l.viewer.ViewTime(w.Time())
+	l.viewer.ViewTime(w.Time(), w.TimeCycle())
 	w.set.Lock()
 	raining, thundering := w.set.Raining, w.set.Raining && w.set.Thundering
 	w.set.Unlock()