feat: Detect orientation of AVIF source images #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVIF Orientation Detection
Resolves #264.
This change adds orientation-detecting code for the AVIF decoder based on
imirandirottags, allowing for orientation normalization.These images can be used to test the implementation, as they contain every combination of
imirandirottags. All of them now look correct after transcoding.Sidenote:
NormalizeOrientationAs a sidenote, from what I can tell, the
NormalizeOrientationflag for anImageOptionsobject doesn't actually do anything. It's never checked anywhere, and thenormalizeOrientation()function is actually called unconditionally in the below-listed section of the code, so it's effectively always treated astrue.lilliput/ops.go
Line 329 in 686cbce
I didn't fix that here because there is no decent fallback at the moment to use when it is
false(like preserving orientation metadata instead), but I figured I'd give y'all a heads-up about it anyway in case you want to make it do something.