Skip to content

ai-gov: update deny rule behavior and add new flag - #25714

Open
craig-osterhout wants to merge 2 commits into
docker:mainfrom
craig-osterhout:update-sbx-local-deny-under-org-governance
Open

ai-gov: update deny rule behavior and add new flag#25714
craig-osterhout wants to merge 2 commits into
docker:mainfrom
craig-osterhout:update-sbx-local-deny-under-org-governance

Conversation

@craig-osterhout

@craig-osterhout craig-osterhout commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

Update governance docs for local deny rules.

  • Clarified that local deny rules are evaluated under org governance and layer on top of org policy. Only allow rules are inactive.
  • Added examples of the --deny-network flag (new in v0.38) on sbx create and sbx run, which sets per-sandbox deny rules at creation time.

https://deploy-preview-25714--docsdocker.netlify.app/ai/sandboxes/governance/

Related issues or tickets

https://docker.slack.com/archives/C097C5LRXFF/p1785455753455409

Reviews

  • Technical review
  • Editorial review
  • Product review

Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit aa24bbf
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a721652bc00e50008eadd64
😎 Deploy Preview https://deploy-preview-25714--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@craig-osterhout craig-osterhout added this to the sbx/v0.38.0 milestone Aug 4, 2026
@craig-osterhout craig-osterhout added the status/review Pull requests that are ready for review label Aug 4, 2026
@craig-osterhout
craig-osterhout requested a review from a team August 4, 2026 16:25

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The changes clearly and consistently clarify the distinction between local allow rules (inactive under org governance) and local deny rules (still evaluated and layering on top of org policy). The new --deny-network flag examples are accurate and well-integrated. No style violations, no vendored files, no missing redirects.

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The changes correctly and consistently update the governance documentation across all three files to reflect that local deny rules remain active under org governance while local allow rules do not. The new --deny-network flag examples for sbx create and sbx run are accurate and well-placed. No style violations, broken commands, or missing redirects detected.

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

No significant issues found. The changes correctly document that local deny rules remain active under org governance while local allow rules are inactive, and add clear examples of the new --deny-network flag for sbx create and sbx run. Content is accurate, well-structured, and follows Docker documentation style guidelines.

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

Comment thread content/manuals/ai/sandboxes/governance/local.md
Comment thread content/manuals/ai/sandboxes/governance/org.md Outdated

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR cleanly updates the AI sandbox governance documentation to reflect the new deny-rule behavior and adds the --deny-network flag documentation. No issues found.

What was reviewed:

  • concepts.md — updated description of local deny vs. allow rule behavior under org governance
  • local.md — added --deny-network flag usage for sbx create and sbx run
  • org.md — clarified that only allow rules are inactive under org governance

All added content is factually precise, uses correct inline code formatting for flags and commands, follows Docker style guide conventions (no AI-isms, no bold misuse, no heading violations), and requires no redirects (no pages removed or renamed).

Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ai status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants