Skip to content

Commit 71ff6ef

Browse files
authored
[CI] Fix Outerloop workflow, and run the workflows every four hours (#13304)
* Fix Outerloop workflow, and run Quarantine tests every four hours * Fix run_tests job to run when build_packages is skipped - Add !cancelled() && !failure() condition to run_tests job so it proceeds when build_packages is skipped (requiresNugets is false) - Update results job failure check to not fail when build_packages is skipped, since that's expected behavior
1 parent 0833383 commit 71ff6ef

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

.github/workflows/specialized-test-runner.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
fail-fast: false
109109
matrix:
110110
tests: ${{ fromJson(needs.generate_tests_matrix.outputs.runsheet) }}
111-
if: ${{ github.repository_owner == 'dotnet' && needs.generate_tests_matrix.result == 'success' && (needs.build_packages.result == 'success' || needs.build_packages.result == 'skipped') }}
111+
if: ${{ github.repository_owner == 'dotnet' && !cancelled() && !failure() }}
112112
uses: ./.github/workflows/run-tests.yml
113113
with:
114114
testShortName: ${{ matrix.tests.project }}
@@ -184,7 +184,19 @@ jobs:
184184
- name: Fail if any dependency failed
185185
# 'skipped' can be when a transitive dependency fails and the dependent job gets 'skipped'.
186186
# For example, one of setup_* jobs failing and the Integration test jobs getting 'skipped'
187-
if: ${{ always() && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped')) }}
187+
# Note: build_packages being skipped is expected when requiresNugets is false, so we check it separately
188+
if: >-
189+
${{
190+
always() && (
191+
needs.generate_tests_matrix.result == 'failure' ||
192+
needs.generate_tests_matrix.result == 'cancelled' ||
193+
needs.run_tests.result == 'failure' ||
194+
needs.run_tests.result == 'cancelled' ||
195+
needs.run_tests.result == 'skipped' ||
196+
(needs.build_packages.result == 'failure') ||
197+
(needs.build_packages.result == 'cancelled')
198+
)
199+
}}
188200
run: |
189201
echo "One or more dependent jobs failed."
190202
exit 1

.github/workflows/tests-quarantine.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ on:
1414
workflow_dispatch:
1515

1616
schedule:
17-
- cron: '0 2,14 * * *' # Twice daily at 02:00 and 14:00 UTC
17+
# Run every 4 hours
18+
- cron: '0 */4 * * *'
1819

1920
# TEMPORARILY DISABLED pull_request trigger due to #12143 (disk space issues): https://github.com/dotnet/aspire/issues/12143
2021
# pull_request:

0 commit comments

Comments
 (0)