[Automated] Update API Surface Area #13290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
captainsafia and
eerhardt
as code owners
github-actions
bot
added
the
NO-MERGE
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13290Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13290" |
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
b1640c4 to
2ecc645
Compare
eerhardt
reviewed
Dec 3, 2025
| public System.Threading.Tasks.ValueTask<string?> GetValueAsync(System.Threading.CancellationToken cancellationToken) { throw null; } | ||
| } | ||
|
|
||
| public sealed partial class PortAllocator : IPortAllocator |
Member
There was a problem hiding this comment.
@davidfowl - does this need to be public? Or only the interface?
| System.Threading.Tasks.ValueTask<string?> IValueProvider.GetValueAsync(System.Threading.CancellationToken cancellationToken) { throw null; } | ||
| } | ||
|
|
||
| [System.Diagnostics.CodeAnalysis.Experimental("ASPIRECOMPUTE001", UrlFormat = "https://aka.ms/aspire/diagnostics/{0}")] |
Member
There was a problem hiding this comment.
@captainsafia - I don't think these should reuse ASPIRECOMPUTE001. As that was already taken:
| public required ImagePullPolicy ImagePullPolicy { get { throw null; } set { } } | ||
| } | ||
|
|
||
| [System.Diagnostics.CodeAnalysis.Experimental("ASPIRECOMPUTE002", UrlFormat = "https://aka.ms/aspire/diagnostics#{0}")] |
github-actions
bot
force-pushed
the
update-api-diffs
branch
3 times, most recently
from
72f1f26 to
d2eff89
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
d2eff89 to
04c84bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.