Skip to content

Quick command panel not closing when pressing escape #16660

@dmm9

Description

@dmm9

Bug Description:

Starting conditions: The notification panel is open (one or more notifications are currently shown). Then, open the quick command panel with F1.

When pressing escape, the quick command panel does not get closed even when it has the focus. Instead, the notifications panel gets closed.

The root cause seems to be a wrong precedence of global keydown events. By relying only on global key events, we are obviating the DOM hierarchy for events. Maybe installing a keydown event listener directly on the quick-pick-service component would be more appropriate.

Steps to Reproduce:

  1. Have some notification (toast) open
  2. Open quick command palette (F1)
  3. Press Escape

Expected: Command palette gets closed, notification panel stays open
Actual: Command palette stays open, notification panel gets closed

Additional Information

Metadata

Metadata

Assignees

Labels

bugbugs found in the applicationquick-openissues related to the quick-open

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions