Update compile-references.js package is a reserved keyword

[lemanschik]

The code did only work because it got bundled or maybe executed without use strict even when it is annotated with it how ever package is a reserved word so renamed it to pkg

What it does

How to test

Follow-ups

Breaking changes

• This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

Hey @lemanschik, thanks for the contribution! You're right, it likely works because we don't run the script with "use strict".

In order to accept your changes, please sign the Eclipse Contributor Agreement (ECA) with the same email that was used to create the commits.

[lemanschik]

@msujew oh thats a problem i do not know what email address is used for that commits please simple apply that on your name i do not want to pull that patch-1 branch and run

git log --pretty=format:"%ae" -n 1

[lemanschik]

in my fork i do clean rewrites anyway via plugins.

  preserveEntrySignatures: true,
  plugins: [
    aliasesTheia,
    patchModulesPlugin({
      [path.resolve('src/theia/scripts/compile-references.js')]: (code, id) => {
        const modified = code.replace('async package =>','async pkg =>').replace('package => package.name','pkg => pkg.name')
        if (modified !== code) {
          console.log('patchModulesPlugin: patched => ',id);
        }
        return modified
      }
    }),
    ```