fixing node tests and renaing them

"node" was too vague a name, our filtering was causing it to match over parts of other scenarios.

Author: ef4

packages/compat/src/audit.ts

@@ -534,6 +534,12 @@ export class Audit {
   private async resolveDeps(deps: string[], fromFile: string): Promise<InternalModule['resolved']> {
     let resolved = new Map() as NonNullable<InternalModule['resolved']>;
     for (let dep of deps) {
+      if (['@embroider/macros'].includes(dep)) {
+        // the audit process deliberately removes the @embroider/macros babel
+        // plugins, so the imports are still present and should be left alone.
+        continue;
+      }
+
       let resolution = await this.resolver.nodeResolve(dep, fromFile);
       switch (resolution.type) {
         case 'virtual':
@@ -542,11 +548,6 @@ export class Audit {
           this.scheduleVisit(resolution.filename, fromFile);
           break;
         case 'not_found':
-          if (['@embroider/macros', '@ember/template-factory'].includes(dep)) {
-            // the audit process deliberately removes the @embroider/macros babel
-            // plugins, so the imports are still present and should be left alone.
-            continue;
-          }
           resolved.set(dep, { isResolutionFailure: true as true });
           break;
         case 'real':

test-packages/support/suite-setup-util.ts

@@ -27,7 +27,7 @@ async function githubMatrix() {
       dir,
     })),
     ...suites
-      .filter(s => s.name !== 'node') // TODO: node tests do not work under windows yet
+      .filter(s => s.name !== 'jest-suites') // TODO: jest tests do not work under windows yet
       .filter(s => !s.name.includes('watch-mode')) // TODO: watch tests are far too slow on windows right now
       .map(s => ({
         name: `${s.name} windows`,

tests/scenarios/jest-suites-test.ts

@@ -7,7 +7,7 @@ const { module: Qmodule, test } = QUnit;
 // this is the bridge between our older Jest-based node tests and our newer
 // scenario-tester powered tests
 Scenarios.fromProject(() => new Project('node-tests'))
-  .map('node', () => {})
+  .map('jest-suites', () => {})
   .forEachScenario(scenario => {
     Qmodule(scenario.name, function () {
       test('run node tests', async function (assert) {