Player velocity not reset on point-to-point use of teleporter

[felixwalberg]

Threadbare version

v0.2.1-27-gcee61e11

Affected scene

No response

Description

If the player enters the CollisionShape2D of a teleporter.tscn while moving, that movement velocity "leaks" out of the teleportation, and the player will continue moving in that direction temporarily.

I can recreate this by running into a teleporter and letting go of the keyboard controls before the animation finishes, and the player will run into a wall near the target spawn_point_path.

This behavior does not seem to occur when the target is a different scene from the one the teleporter exists in.

Screen.Recording.2026-07-22.at.2.17.19.PM.mov

Checklist

• I've reviewed and agree to follow the code of conduct

[manuq]

We haven't tested teleporters to the same scene in a while!

[wjt]

I think it's because Player.take_control() changes mode to Mode.SYSTEM_CONTROLLED which stops new input events being handled by input_walk_behavior.gd; but it doesn't reset InputWalkBehavior.input_vector and .is_running. So the "button released" events for those (assuming you release the joystick during the fade) are ignored, and then when Player.return_control() changes the mode back to USER_CONTROLLED, the old input_vector is still non-zero and the player keeps moving.

You can also sometimes see this when you start an interaction while moving.

(The reason it doesn't happen when switching scenes is that in that case the player in the new scene is a fresh instance.)

[wjt]

One thing I noticed in our team playthrough of Chants of Sennaar: in that game, teleporters are interactable. You can activate them either by hitting the "interact" button (Xbox A / PlayStation X, just like in Threadbare) or by walking through them. Once activated, manual character control is taken away. The player walks along a fixed path on both sides of the transition; then control is returned.

If the Player scene had a walk_to(point: Marker2D) method, then you could imagine having a "walk-off point" associated with a Teleporter and a "walk-on point" associated with a spawn-point; then Teleporter would take control of the player and make it walk to the walk-off point while the screen fades out, and then when a spawn point positions the player, it would actually make the player walk along a straight line define by a pair of points before returning control.

Or the Player scene could have a PathWalkBehavior and we could activate that in each case.