Merge remote-tracking branch 'origin/develop' into wip/jtulach/AverageOverByteBuffer13851

Author: JaroslavTulach

CHANGELOG.md

@@ -14,6 +14,7 @@
   is included][14028]
 - [Function docs in autocomplete in table expressions][14059]
 - [Many CLI arguments removed][14069]
+- [Support opening project by clicking on link in documentation][14136]
 - [Images may be added to assets descriptions][14247]
 - [Dragging edges from plus button on nodes is now possible][14246]
 - [JSON and SQL visualizations' content may be now selected and copied][14262]
@@ -27,6 +28,8 @@
   top.
 - [Context menu for connections][14325].
 - [Warnings and Errors no longer become transparent][14388]
+- [GeoMap visualization is now working without need of Mapbox Token in
+  environment][14429]
 
 [13685]: https://github.com/enso-org/enso/pull/13685
 [13658]: https://github.com/enso-org/enso/pull/13658
@@ -39,6 +42,7 @@
 [13976]: https://github.com/enso-org/enso/pull/13976
 [14059]: https://github.com/enso-org/enso/pull/14059
 [14069]: https://github.com/enso-org/enso/pull/14069
+[14136]: https://github.com/enso-org/enso/pull/14136
 [14247]: https://github.com/enso-org/enso/pull/14247
 [14262]: https://github.com/enso-org/enso/pull/14262
 [14246]: https://github.com/enso-org/enso/pull/14246
@@ -49,6 +53,7 @@
 [14267]: https://github.com/enso-org/enso/pull/14267
 [14325]: https://github.com/enso-org/enso/pull/14325
 [14388]: https://github.com/enso-org/enso/pull/14388
+[14429]: https://github.com/enso-org/enso/pull/14429
 
 #### Enso Standard Library
 
@@ -74,9 +79,11 @@
 - [Initial Spatial support within DuckDB][14331]
 - [Add email SMTP support][14350]
 - [Read files into DuckDB both spatial and not.][14367]
-- [Implement Text_Column to_case for DB backends][14386]
-- [Implement bulk loading to DuckDB][14402]
-- [Initial file writing from DuckDB][14421]
+- [Implement Text_Column to_case for DB backends.][14386]
+- [Implement bulk loading to DuckDB.][14402]
+- [Implement `Text_Column.text_mid` for in-memory and database backends.][14420]
+- [Initial file writing from DuckDB.][14421]
+- [Parquet file reading and writing, DuckDB formats.][14427]
 
 [13769]: https://github.com/enso-org/enso/pull/13769
 [14026]: https://github.com/enso-org/enso/pull/14026
@@ -101,7 +108,9 @@
 [14367]: https://github.com/enso-org/enso/pull/14367
 [14386]: https://github.com/enso-org/enso/pull/14386
 [14402]: https://github.com/enso-org/enso/pull/14402
+[14420]: https://github.com/enso-org/enso/pull/14420
 [14421]: https://github.com/enso-org/enso/pull/14421
+[14427]: https://github.com/enso-org/enso/pull/14427
 
 #### Enso Language & Runtime
 

app/common/src/services/Backend.ts

@@ -635,10 +635,17 @@ export interface CreateCustomerPortalSessionResponse {
 /** Response from the "path/resolve" endpoint. */
 export interface PathResolveResponse extends Omit<AnyRealAsset, 'type' | 'ensoPath'> {}
 
+/** Whether a type is `any`. */
+type IsAny<T> = 0 extends 1 & T ? true : false
+
 /** Response from "assets/${assetId}" endpoint. */
 export type AssetDetailsResponse<Id extends AssetId> =
-  | (Asset<AssetTypeFromId<Id>> & { readonly metadataId: MetadataId })
-  | null
+  // `T extends T` where `T` is a type parameter is a trick to distribute union values,
+  // evaluating the conditional type for each member of the union type,
+  // and then resolving to a union of the results of this operation.
+  IsAny<Id> extends true ? AssetDetailsResponse<AssetId>
+  : | (Id extends Id ? AnyAsset<AssetTypeFromId<Id>> & { readonly metadataId: MetadataId } : never)
+    | null
 
 /** Whether the user is on a plan with multiple seats (i.e. a plan that supports multiple users). */
 export function isUserOnPlanWithMultipleSeats(user: User) {
@@ -1648,6 +1655,15 @@ export function isNewTitleUnique(
   )
 }
 
+export const MAPBOX_TOKEN_SCHEMA = z.object({
+  token: z.string(),
+  expires: z
+    .string()
+    .datetime({ offset: true })
+    .transform((str) => new Date(str)),
+})
+export type MapboxToken = z.infer<typeof MAPBOX_TOKEN_SCHEMA>
+
 /** Network error class. */
 export class NetworkError extends Error {
   /**
@@ -2014,6 +2030,8 @@ export abstract class Backend {
   abstract createApiKey(body: CreateApiKeyRequestBody): Promise<ApiKey>
   /** Delete a API key for the current user. */
   abstract deleteApiKey(apiKeyId: ApiKeyId): Promise<void>
+  /** Retrieve Mapbox token for the current user. */
+  abstract getMapboxToken(): Promise<MapboxToken>
 
   /** Throw a {@link backend.NotAuthorizedError} if the response is a 401 Not Authorized status code. */
   private async checkForAuthenticationError<T>(

app/common/src/services/Backend/ensoPath.ts

@@ -0,0 +1,15 @@
+import { newtypeConstructor, type Newtype } from '../../utilities/data/newtype.js'
+
+/** The path of this asset, including the root directory. */
+export type EnsoPath = Newtype<string, 'EnsoPath'>
+export const EnsoPath = newtypeConstructor<EnsoPath>()
+
+/** The path string of this asset, including the root directory. */
+export type EnsoPathValue = Newtype<string, 'EnsoPathValue'>
+export const EnsoPathValue = newtypeConstructor<EnsoPathValue>()
+
+/** Checks if paths are equal, ignoring subsequent `/`. */
+export function ensoPathEq(a: EnsoPath, b: EnsoPath) {
+  const normalize = (x: EnsoPath) => x.replaceAll(/\/+/g, '/')
+  return normalize(a) === normalize(b)
+}

app/common/src/services/Backend/remoteBackendPaths.ts

@@ -103,6 +103,7 @@ export const CREATE_API_KEY_PATH = 'credentials'
 export function deleteApiKeyPath(apiKeyId: ApiKeyId) {
   return `credentials/${apiKeyId}`
 }
+export const GET_MAPBOX_TOKEN_PATH = 'mapbox/token'
 
 /** Relative HTTP path to the "cancel subscription" endpoint of the Cloud backend API. */
 export function cancelSubscriptionPath(subscriptionId: SubscriptionId) {

app/common/src/services/Backend/types.ts

@@ -1,5 +1,6 @@
 import { newtypeConstructor, type Newtype } from '../../utilities/data/newtype.js'
 import type { IdType } from '../Backend.js'
+export { EnsoPath, EnsoPathValue } from './ensoPath.js'
 
 /** A KSUID. */
 export type KSUID = Newtype<string, 'KSUID'>
@@ -161,14 +162,6 @@ export const ParentsPath = newtypeConstructor<ParentsPath>()
 export type VirtualParentsPath = Newtype<string, 'VirtualParentsPath'>
 export const VirtualParentsPath = newtypeConstructor<VirtualParentsPath>()
 
-/** The path of this asset, including the root directory. */
-export type EnsoPath = Newtype<string, 'EnsoPath'>
-export const EnsoPath = newtypeConstructor<EnsoPath>()
-
-/** The path string of this asset, including the root directory. */
-export type EnsoPathValue = Newtype<string, 'EnsoPathValue'>
-export const EnsoPathValue = newtypeConstructor<EnsoPathValue>()
-
 /** A pagination token for an arbitrary endpoint. */
 export type PaginationToken = Newtype<string, 'PaginationToken'>
 export const PaginationToken = newtypeConstructor<PaginationToken>()

app/common/src/services/LocalBackend.ts

@@ -778,7 +778,7 @@ export class LocalBackend extends backend.Backend {
 
   /** Resolve path to asset. In case of LocalBackend, this is just the filesystem path. */
   override resolveEnsoPath(path: backend.EnsoPath): Promise<backend.PathResolveResponse> {
-    const { directoryPath } = getDirectoryAndName(Path(path as string))
+    const { directoryPath } = getDirectoryAndName(Path(String(path)))
     return this.findAsset(directoryPath, 'ensoPath', path)
   }
 
@@ -1123,6 +1123,11 @@ export class LocalBackend extends backend.Backend {
     return this.invalidOperation()
   }
 
+  /** Invalid operation */
+  override getMapboxToken() {
+    return this.invalidOperation()
+  }
+
   /** Find asset details using directory listing. */
   private async findAsset<Key extends keyof backend.AnyAsset>(
     directory: Path,

app/common/src/services/RemoteBackend.ts

@@ -208,10 +208,10 @@ export class RemoteBackend extends backend.Backend {
     params: backend.UploadPictureRequestParams,
     file: Blob,
   ): Promise<backend.User> {
-    const paramsString = new URLSearchParams({
+    const paramsString = new URLSearchParams(
       // eslint-disable-next-line camelcase
-      ...(params.fileName != null ? { file_name: params.fileName } : {}),
-    }).toString()
+      params.fileName != null ? { file_name: params.fileName } : {},
+    ).toString()
     const path = `${remoteBackendPaths.UPLOAD_USER_PICTURE_PATH}?${paramsString}`
     const response = await this.putBinary<backend.User>(path, file)
     if (!response.ok) {
@@ -279,10 +279,10 @@ export class RemoteBackend extends backend.Backend {
     params: backend.UploadPictureRequestParams,
     file: Blob,
   ): Promise<backend.OrganizationInfo> {
-    const paramsString = new URLSearchParams({
+    const paramsString = new URLSearchParams(
       // eslint-disable-next-line camelcase
-      ...(params.fileName != null ? { file_name: params.fileName } : {}),
-    }).toString()
+      params.fileName != null ? { file_name: params.fileName } : {},
+    ).toString()
     const path = `${remoteBackendPaths.UPLOAD_ORGANIZATION_PICTURE_PATH}?${paramsString}`
     const response = await this.putBinary<backend.OrganizationInfo>(path, file)
     if (!response.ok) {
@@ -808,9 +808,9 @@ export class RemoteBackend extends backend.Backend {
     params: backend.GetProjectSessionLogsRequestParams,
     title: string,
   ): Promise<backend.ProjectSessionLogs> {
-    const queryParams = new URLSearchParams({
-      ...(params.scrollId != null ? { scrollId: params.scrollId } : {}),
-    })
+    const queryParams = new URLSearchParams(
+      params.scrollId != null ? { scrollId: params.scrollId } : {},
+    )
     const path = remoteBackendPaths.getProjectSessionLogsPath(projectSessionId)
     const response = await this.get<backend.ProjectSessionLogs>(path, queryParams)
     if (!response.ok) {
@@ -1270,6 +1270,16 @@ export class RemoteBackend extends backend.Backend {
     }
   }
 
+  /** Retrieve Mapbox token for the current user. */
+  override async getMapboxToken(): Promise<backend.MapboxToken> {
+    const response = await this.get(remoteBackendPaths.GET_MAPBOX_TOKEN_PATH)
+    if (!response.ok) {
+      return await this.throw(response, 'getMapboxTokenBackendError')
+    } else {
+      return backend.MAPBOX_TOKEN_SCHEMA.parse(await response.json())
+    }
+  }
+
   /**
    * Cancel given subscription.
    * @throws An error if a non-successful status code (not 200-299) was received.
@@ -1329,10 +1339,7 @@ export class RemoteBackend extends backend.Backend {
       {
         message,
         projectId,
-        metadata: {
-          timestamp: new Date().toISOString(),
-          ...(metadata ?? {}),
-        },
+        metadata: { timestamp: new Date().toISOString(), ...metadata },
       },
       {
         keepalive: true,
@@ -1471,9 +1478,10 @@ export class RemoteBackend extends backend.Backend {
 
   /** Resolve asset metadata from an enso path. */
   override async resolveEnsoPath(path: backend.EnsoPath): Promise<backend.PathResolveResponse> {
+    const effectivePath = backend.EnsoPath(path.replace(/%20/g, ' '))
     const response = await this.get<backend.Asset<backend.RealAssetType>>(
       remoteBackendPaths.RESOLVE_ENSO_PATH,
-      { path },
+      { path: effectivePath },
     )
 
     if (!response.ok) return this.throw(response, 'resolveEnsoPathBackendError')

app/common/src/text/english.json

@@ -1095,10 +1095,6 @@
   "ensoDevtoolsFeatureFlags": "Feature Flags",
   "ensoDevtoolsFeatureFlags.showDeveloperIds": "Show Developer Ids",
   "ensoDevtoolsFeatureFlags.showDeveloperIdsDescription": "Show object ids for debugging purposes.",
-  "ensoDevtoolsFeatureFlags.overrideProfilePicture": "Override Profile Picture",
-  "ensoDevtoolsFeatureFlags.overrideProfilePictureDescription": "Override the user's profile picture with a fixed image.",
-  "ensoDevtoolsFeatureFlags.multiplyUserList": "Multiply User List",
-  "ensoDevtoolsFeatureFlags.multiplyUserListDescription": "Multiply each user in the user list to simulate more users.",
   "ensoDevtoolsFeatureFlags.enableMultitabs": "Enable Multitabs",
   "ensoDevtoolsFeatureFlags.enableMultitabsDescription": "Allow multiple asset panels to be open at the same time.",
   "ensoDevtoolsFeatureFlags.enableAssetsTableBackgroundRefresh": "Enable Assets Table Background Refresh",
@@ -1269,6 +1265,7 @@
   "listApiKeysBackendError": "Could not list API keys.",
   "createApiKeyBackendError": "Could not create API key.",
   "deleteApiKeyBackendError": "Could not delete API key.",
+  "getMapboxTokenBackendError": "Could not retrieve Mapbox token.",
   "keyId": "Access key",
   "secretId": "Secret access key",
   "accessKeyAlert": "If you lose or forget your secret access key, you cannot retrieve it. Instead, create a new access key and make the old key inactive.",

app/gui/src/components/AppContainer/AppContainer.vue

@@ -1,4 +1,5 @@
 <script lang="ts">
+import { ModalWrapper as ModalWrapperReact } from '#/components/ModalWrapper'
 import type { PaywallFeatureName } from '#/hooks/billing'
 import { UserBar as UserBarReact } from '#/pages/dashboard/UserBar'
 import CommandPalette from '$/components/CommandPalette.vue'
@@ -25,6 +26,7 @@ import { Drive, Settings } from './reactTabs'
 import RightPanel from './RightPanel.vue'
 import SelectableTab from './SelectableTab.vue'
 
+const ModalWrapper = reactComponent(ModalWrapperReact)
 const UserBar = reactComponent(UserBarReact)
 </script>
 
@@ -130,6 +132,7 @@ onUnmounted(() => {
   <div class="TabView">
     <CommandPalette />
     <ContainerProviderForReact>
+      <ModalWrapper />
       <div class="bar">
         <div role="tablist" class="tablist">
           <SelectableTab
@@ -176,10 +179,7 @@ onUnmounted(() => {
             <Drive v-if="tab === 'drive'" />
           </KeepAlive>
           <KeepAlive v-for="project in projectTabs" :key="project.state.info.id">
-            <ProjectView
-              v-if="tab === project.state.info.ensoPath"
-              :projectId="project.state.info.id"
-            />
+            <ProjectView v-if="project.shown.value" :projectId="project.state.info.id" />
           </KeepAlive>
           <KeepAlive>
             <Settings v-if="tab === 'settings'" />

app/gui/src/dashboard/components/Devtools/EnsoDevtoolsImpl.tsx

@@ -68,7 +68,6 @@ function DeveloperOverrideEntry(props: DeveloperOverrideEntryProps) {
 
 /** A display of current developer overrides. */
 export function EnsoDevStatus() {
-  const queryClient = useQueryClient()
   const { getText } = useText()
   const showEnsoDevtools = useShowEnsoDevtools()
   const versionCheckerEnabled = useEnableVersionChecker() ?? false
@@ -81,8 +80,6 @@ export function EnsoDevStatus() {
     assetsTableBackgroundRefreshInterval,
     enableCloudExecution,
     enableAdvancedProjectExecutionOptions,
-    overrideProfilePicture,
-    multiplyUserList,
     listDirectoryPageSize,
     getLogEventsPageSize,
     fileChunkUploadPoolSize,
@@ -111,8 +108,6 @@ export function EnsoDevStatus() {
     assetsTableBackgroundRefreshInterval !== DEFAULT_ASSETS_TABLE_REFRESH_INTERVAL_MS ||
     !enableCloudExecution ||
     showDeveloperIds ||
-    overrideProfilePicture ||
-    multiplyUserList ||
     enableMultitabs ||
     enableAdvancedProjectExecutionOptions ||
     listDirectoryPageSize !== DEFAULT_LIST_DIRECTORY_PAGE_SIZE ||
@@ -190,25 +185,6 @@ export function EnsoDevStatus() {
             {getText('showingDeveloperIds')}
           </DeveloperOverrideEntry>
         )}
-        {overrideProfilePicture && (
-          <DeveloperOverrideEntry
-            reset={() => {
-              setFeatureFlag('overrideProfilePicture', false)
-            }}
-          >
-            {getText('overridingProfilePicture')}
-          </DeveloperOverrideEntry>
-        )}
-        {multiplyUserList && (
-          <DeveloperOverrideEntry
-            reset={async () => {
-              setFeatureFlag('multiplyUserList', false)
-              await queryClient.invalidateQueries({ queryKey: ['remote', 'listUsers'] })
-            }}
-          >
-            {getText('multiplyingUserList')}
-          </DeveloperOverrideEntry>
-        )}
         {enableMultitabs && (
           <DeveloperOverrideEntry
             reset={() => {
@@ -427,27 +403,6 @@ export function EnsoDevtools() {
                     setFeatureFlag('showDeveloperIds', value)
                   }}
                 />
-                <Switch
-                  form={form}
-                  name="overrideProfilePicture"
-                  label={getText('ensoDevtoolsFeatureFlags.overrideProfilePicture')}
-                  description={getText(
-                    'ensoDevtoolsFeatureFlags.overrideProfilePictureDescription',
-                  )}
-                  onChange={(value) => {
-                    setFeatureFlag('overrideProfilePicture', value)
-                  }}
-                />
-                <Switch
-                  form={form}
-                  name="multiplyUserList"
-                  label={getText('ensoDevtoolsFeatureFlags.multiplyUserList')}
-                  description={getText('ensoDevtoolsFeatureFlags.multiplyUserListDescription')}
-                  onChange={async (value) => {
-                    setFeatureFlag('multiplyUserList', value)
-                    await queryClient.invalidateQueries({ queryKey: ['remote', 'listUsers'] })
-                  }}
-                />
                 <Switch
                   form={form}
                   name="enableMultitabs"