fix(p2p/libp2p): redirect p2p-forge zap logger output to stdout#5393
Open
gacevicljubisa wants to merge 1 commit intomasterfrom
Open
fix(p2p/libp2p): redirect p2p-forge zap logger output to stdout#5393gacevicljubisa wants to merge 1 commit intomasterfrom
gacevicljubisa wants to merge 1 commit intomasterfrom
Conversation
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos,
martinconic and
sbackend123
martinconic
approved these changes
Mar 12, 2026
akrem-chabchoub
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The zap logger created for the p2p-forge certificate manager was configured to write to
stderr(OutputPaths: ["stderr"],ErrorOutputPaths: ["stderr"]). However, bee's own logger is instantiated withcmd.OutOrStdout()as its sink, which defaults toos.Stdout. This caused p2p-forge/certmagic logs to be emitted to a different stream than all other bee logs.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):