feat: Remove cpr dependency and CMake variable leaks (#14160)

Summary:
cpr requires a specific libcurl version and is not portable. The current usage can be replaced by
libcurl which is present on most distros.
When cuDF is enabled, curl is bundled. Use the system or bundled curl otherwise for testing.
When a dependency uses `option` for a variable, it gets cached and becomes global.
However, if the variable is defined before, it does not get cached in some instances.
This PR unsets commonly used CMake variables BUILD_TESTING and BUILD_SHARED_LIBS if set by a dependency.

Pull Request resolved: #14160

Reviewed By: amitkdutta

Differential Revision: D86775547

Pulled By: peterenescu

fbshipit-source-id: f1a76ada3a86d47024f87b7b10a7e49092d002c9

Author: majetideepak

CMake/resolve_dependency_modules/README.md

@@ -39,7 +39,6 @@ by Velox. See details on bundling below.
 | fbthrift          | v2025.04.28.00  | No       ||
 | libstemmer        | 2.2.0           | Yes      ||
 | DuckDB (testing)  | 0.8.1           | Yes      ||
-| cpr (testing)     | 1.10.15         | Yes      ||
 | arrow             | 15.0.0          | Yes      ||
 | geos              | 3.10.7          | Yes      ||
 | fast_float        | v8.0.2          | Yes      ||

CMake/resolve_dependency_modules/cpr.cmake

@@ -114,4 +114,5 @@ block(SCOPE_FOR VARIABLES)
   )
 
   unset(BUILD_SHARED_LIBS)
+  unset(BUILD_TESTING CACHE)
 endblock()

CMake/resolve_dependency_modules/cpr/cpr-libcurl-compatible.patch

@@ -13,19 +13,4 @@
 # limitations under the License.
 include_guard(GLOBAL)
 
-set(VELOX_CURL_VERSION 8.4.0)
-string(REPLACE "." "_" VELOX_CURL_VERSION_UNDERSCORES ${VELOX_CURL_VERSION})
-set(
-  VELOX_CURL_BUILD_SHA256_CHECKSUM
-  16c62a9c4af0f703d28bda6d7bbf37ba47055ad3414d70dec63e2e6336f2a82d
-)
-string(
-  CONCAT
-  VELOX_CURL_SOURCE_URL
-  "https://github.com/curl/curl/releases/download/"
-  "curl-${VELOX_CURL_VERSION_UNDERSCORES}/curl-${VELOX_CURL_VERSION}.tar.xz"
-)
-
-velox_resolve_dependency_url(CURL)
-
-FetchContent_Declare(curl URL ${VELOX_CURL_SOURCE_URL} URL_HASH ${VELOX_CURL_BUILD_SHA256_CHECKSUM})
+add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/curl)

CMake/resolve_dependency_modules/cpr/cpr-remove-sancheck.patch

@@ -0,0 +1,42 @@
+# Copyright (c) Facebook, Inc. and its affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set(VELOX_CURL_VERSION 8.4.0)
+string(REPLACE "." "_" VELOX_CURL_VERSION_UNDERSCORES ${VELOX_CURL_VERSION})
+set(
+  VELOX_CURL_BUILD_SHA256_CHECKSUM
+  16c62a9c4af0f703d28bda6d7bbf37ba47055ad3414d70dec63e2e6336f2a82d
+)
+string(
+  CONCAT
+  VELOX_CURL_SOURCE_URL
+  "https://github.com/curl/curl/releases/download/"
+  "curl-${VELOX_CURL_VERSION_UNDERSCORES}/curl-${VELOX_CURL_VERSION}.tar.xz"
+)
+
+set(BUILD_TESTING OFF)
+set(BUILD_SHARED_LIBS ON)
+
+velox_resolve_dependency_url(CURL)
+
+message(STATUS "Building CURL from source")
+
+FetchContent_Declare(curl URL ${VELOX_CURL_SOURCE_URL} URL_HASH ${VELOX_CURL_BUILD_SHA256_CHECKSUM})
+
+FetchContent_MakeAvailable(curl)
+
+# Curl uses CMake option for BUILD_TESTING and BUILD_SHARED_LIBS
+# See CMake option semantics.
+unset(BUILD_TESTING CACHE)
+unset(BUILD_SHARED_LIBS CACHE)

CMake/resolve_dependency_modules/cudf.cmake

@@ -44,6 +44,7 @@ FetchContent_Declare(
 # that.
 set(GIT_COMMIT_HASH "6536a77")
 set(BUILD_UNITTESTS OFF)
+set(BUILD_TESTING OFF)
 set(ENABLE_SANITIZER OFF)
 set(ENABLE_UBSAN OFF)
 set(BUILD_SHELL OFF)
@@ -65,3 +66,5 @@ endif()
 
 set(CMAKE_CXX_FLAGS ${PREVIOUS_CMAKE_CXX_FLAGS})
 set(CMAKE_BUILD_TYPE ${PREVIOUS_BUILD_TYPE})
+# Some DuckDB third-party package sets this flags. We cannot control that.
+unset(BUILD_TESTING)

CMake/resolve_dependency_modules/curl.cmake

@@ -60,10 +60,14 @@ FetchContent_Declare(
 # Set build options
 block()
   set(BUILD_SHARED_LIBS OFF)
+  set(BUILD_TESTING OFF)
   set(CMAKE_BUILD_TYPE Release)
   set(FAISS_ENABLE_GPU OFF)
   set(FAISS_ENABLE_PYTHON OFF)
   set(FAISS_ENABLE_GPU_TESTS OFF)
   # Make FAISS available
   FetchContent_MakeAvailable(faiss)
+  add_library(FAISS::faiss ALIAS faiss)
+  unset(BUILD_TESTING CACHE)
+  unset(BUILD_SHARED_LIBS CACHE)
 endblock()

CMake/resolve_dependency_modules/curl/CMakeLists.txt

@@ -60,3 +60,5 @@ set(re2_INCLUDE_DIRS ${re2_SOURCE_DIR})
 
 set(RE2_ROOT ${re2_BINARY_DIR})
 set(re2_ROOT ${re2_BINARY_DIR})
+
+unset(BUILD_TESTING CACHE)