Skip to content

[refactoring] skill: create shared/smoke-engine-base.md for 8 smoke workflows sharing gh+token-telemetry-check+reporting-otlp pattern #47459

Description

@github-actions

Opportunity

8 smoke test workflows (covering different engines: claude, codex, copilot, copilot-arm, copilot-aoai-*, gemini, opencode) share a near-identical import pattern of shared/gh.md + shared/token-telemetry-check.md + shared/reporting-otlp.md (or shared/reporting.md+shared/otlp.md). A shared/smoke-engine-base.md would standardize the smoke test scaffold.

Current Usage

8 workflows with this pattern:

  • smoke-claude.mdgh.md + go-make.md + github-mcp-app.md + otlp.md + token-telemetry-check.md
  • smoke-codex.mdgh.md + reporting-otlp.md + mcp/serena-go.md + otlp.md + token-telemetry-check.md
  • smoke-copilot-aoai-apikey.mdgithub-guard-policy.md + gh.md + reporting.md + github-queries-mcp-script.md + mcp/serena-go.md + otlp.md + token-telemetry-check.md
  • smoke-copilot-aoai-entra.md — same as above
  • smoke-copilot-arm.mdgh.md + reporting-otlp.md + github-queries-mcp-script.md + mcp/serena-go.md + otlp.md + token-telemetry-check.md
  • smoke-copilot.md — same as smoke-copilot-aoai-*
  • smoke-gemini.mdgh.md + reporting-otlp.md + otlp.md + token-telemetry-check.md
  • smoke-opencode.md — same as smoke-gemini.md

Shared core: shared/gh.md + shared/token-telemetry-check.md + shared/reporting-otlp.md appears in all 8.

Proposed Component

shared/smoke-engine-base.md

---
# Smoke test engine base
# Provides the standard scaffold for engine smoke tests:
# gh CLI tools, token telemetry validation, and report+OTLP observability.
#
# Usage:
#   imports:
#     - shared/smoke-engine-base.md

imports:
  - shared/gh.md
  - shared/token-telemetry-check.md
  - shared/reporting-otlp.md
---

Impact

  • 8 workflows affected
  • Medium priority: 8 workflows, clear stable pattern
  • ~3 lines saved per workflow (~24 lines total), but more importantly reduces divergence risk in the smoke test suite
  • Makes it easy to add new engine smoke tests with consistent baseline configuration

Migration Plan

  1. Create shared/smoke-engine-base.md with the content above
  2. For each of the 8 smoke workflows, replace the 3-import combination with shared/smoke-engine-base.md
  3. Engine-specific extras (e.g., shared/mcp/serena-go.md, shared/go-make.md) remain as additional imports
  4. Run make recompile to verify no regressions

Example

# Before (smoke-gemini.md)
imports:
  - shared/gh.md
  - shared/reporting-otlp.md
  - shared/otlp.md
  - shared/token-telemetry-check.md

# After
imports:
  - shared/smoke-engine-base.md

Generated by 🔍 Workflow Skill Extractor · sonnet46 41.6 AIC · ⌖ 8.54 AIC · ⊞ 4.8K ·

  • expires on Jul 24, 2026, 8:48 PM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions