Skip to content

Reordering a stack can cause PRs to be incorrectly marked as merged #411

Description

@adjerbetian

Problem

After reordering a published stack, I ran:

gh stack modify
gh stack push
gh stack submit

gh stack push updated the branch ancestry without updating the existing PR bases. Some PRs then targeted descendant branches that already contained their commits.

GitHub saw empty diffs and automatically marked those PRs as merged, although their commits were never merged into main. The PRs could not be reopened and had to be recreated with new branch names.

Version

gh stack version 0.0.8

Expected behavior

I expected gh stack push either

  • to update the remote stack to match the reordered local stack,
  • or to fail and tell me to use gh stack submit for this operation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions