Skip to content

Commit 3a8f2b5

Browse files
authored
Remove excessive logging statements
1 parent 71de463 commit 3a8f2b5

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

go/pools/smartconnpool/pool.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@ func (pool *ConnPool[C]) put(conn *Pooled[C]) {
379379
var err error
380380
conn, err = pool.connNew(context.Background())
381381
if err != nil {
382-
log.Errorf("======================== connNew ERROR: %s", err)
383382
pool.closedConn()
384383
return
385384
}
@@ -525,7 +524,6 @@ func (pool *ConnPool[C]) get(ctx context.Context) (*Pooled[C], error) {
525524
}
526525
// no connections available and no connections to wait for (pool is closed)
527526
if conn == nil {
528-
log.Errorf("====================== ERROR: conn == nil err")
529527
return nil, ErrTimeout
530528
}
531529

@@ -584,7 +582,6 @@ func (pool *ConnPool[C]) getWithSetting(ctx context.Context, setting *Setting) (
584582
}
585583
// no connections available and no connections to wait for (pool is closed)
586584
if conn == nil {
587-
log.Errorf("====================== getWithSetting ERROR: conn == nil err")
588585
return nil, ErrTimeout
589586
}
590587

go/vt/vttablet/tabletserver/query_executor.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -697,14 +697,12 @@ func (qre *QueryExecutor) execSelect() (*sqltypes.Result, error) {
697697
}
698698
// Check tablet type.
699699
if qre.shouldConsolidate() {
700-
log.Error("============================== WE'RE CONSOLIDATING")
701700
q, original := qre.tsv.qe.consolidator.Create(sqlWithoutComments)
702701
if original {
703702
defer q.Broadcast()
704703
conn, err := qre.getConn()
705704

706705
if err != nil {
707-
log.Errorf("=========================== ERROR WHEN TRYING TO GET CONNECTION WHEN CONSOLIDATING: %s", err)
708706
q.SetErr(err)
709707
} else {
710708
defer conn.Recycle()
@@ -725,15 +723,12 @@ func (qre *QueryExecutor) execSelect() (*sqltypes.Result, error) {
725723
}
726724
conn, err := qre.getConn()
727725
if err != nil {
728-
log.Errorf("====================== ERROR WHEN TRYING TO GET CONNECTION FROM POOL: %s", err.Error())
729726
return nil, err
730727
}
731728
defer conn.Recycle()
732729

733-
log.Info("====================== NO ERROR WHEN TRYING TO GET CONNECTION FROM POOL")
734730
res, err := qre.execDBConn(conn.Conn, sql, true)
735731
if err != nil {
736-
log.Errorf("=========================== ERROR WHEN EXECUTING WITH CONNECTION: %s", err.Error())
737732
return nil, err
738733
}
739734
return res, nil

go/vt/vttablet/tabletserver/tabletserver.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1561,7 +1561,6 @@ func (tsv *TabletServer) execRequest(
15611561

15621562
err = exec(ctx, logStats)
15631563
if err != nil {
1564-
log.Errorf("============================ EXEC ERROR: %s", err.Error())
15651564
return tsv.convertAndLogError(ctx, sql, bindVariables, err, logStats)
15661565
}
15671566
return nil

0 commit comments

Comments
 (0)