Goodhosts' rewrite of the hosts file renders MAMP incapable of managing its entries

[theMikeD]

I am running MAMP Pro and VVV simultaneously, and sometimes concurrently. When MAMP Pro has first crack at the /etc/hosts file, it ends up looking like this:

127.0.0.1	scratch.test	# MAMP PRO - Do NOT remove this entry!
::1		scratch.test	# MAMP PRO - Do NOT remove this entry!
127.0.0.1	clean.test	# MAMP PRO - Do NOT remove this entry!
::1		clean.test	# MAMP PRO - Do NOT remove this entry!
127.0.0.1	cnmd.test	# MAMP PRO - Do NOT remove this entry!
::1		cnmd.test	# MAMP PRO - Do NOT remove this entry!
127.0.0.1	boilerplate.test	# MAMP PRO - Do NOT remove this entry!
::1		boilerplate.test	# MAMP PRO - Do NOT remove this entry!
127.0.0.1	macster.local	# MAMP PRO - Do NOT remove this entry!
::1		macster.local	# MAMP PRO - Do NOT remove this entry!

etc etc. Adding and removing hosts via MAMP Pro works correctly, and shutting down MAMP Pro removes all entries it controls. All fine.

When I fire up MAMP Pro and then fire up VVV, /etc/hosts gets rewritten so that I end up with this

::1 boilerplate.test clean.test cnmd.test macster.local scratch.test # MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!
127.0.0.1 boilerplate.test clean.test cnmd.test macster.local scratch.test # MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!  MAMP PRO - Do NOT remove this entry!
192.168.50.4 vvv vvv.test rfa.test # VAGRANT: 32549be2774dded0939569e71b56d8f1 (default) / 465e8518-e2b5-4ae0-9348-e56e8662ab2d
255.255.255.255 broadcasthost

IOW they have gone from one-per-line pairs to a single entry. This rewrite prevents MAMP from being able to manage its entries.

As technically correct as this may be, this is a bad scene. Is there a way to have GH just do its thing without modifying anything else?

[luthermonson]

i dont think you can use the --clean functionality with a rig like mamp then, the only way to get here is through a clean flag right? i am not missing something that got you here via other use?

[tomjn]

I think this needs migrating to the vagrant repo at https://github.com/goodhosts/vagrant

[luthermonson]

ohhh that makes sense, ill copy/paste and link it and close this

[Mte90]

To me the issue is not just the plugin that does a clean but the fact that the clean command, cleans all the file and just the parts that are involved with goodhosts.

Clean command was implemented to avoid multiple injection of the same rule by goodhosts as a previous ticket so is a problem in both the projects @luthermonson

[luthermonson]

you think there should be a #goodhosts comment or something and just keep everything 100% separate from everyone else?

[Mte90]

yes in this way the user can use clean without worrying.

[luthermonson]

@Mte90 @theMikeD let's do it, if we do some sort of #MANAGED BY GOODHOSTS comment block and only change entries in there it would make the most sense but i feel this requires a 1.1.x version bump, agree?

[Mte90]

Yes to me is good so I can do a new release of the plugin with that and add a flag to enable or not the clean at all.

[tomjn]

This sounds good!

[theMikeD]

Whats the next step?

[luthermonson]

find time to add the feature :D PRs welcome~

[tomjn]

Luther I think the problem is less time and willingness and more that they don’t know how to do it, I know that’s definitely the case here. What would such a PR look like?

…

On Mon, 11 Jan 2021 at 20:22, Luther Monson ***@***.***> wrote: find time to add the feature :D PRs welcome~ — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOLZ55NORZI7TLYW4ORJLSZNMYLANCNFSM4VMGYQEQ> .