Skip to content

Commit 524502e

Browse files
author
Dillon Nys
committed
Clean up
1 parent f200385 commit 524502e

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

mono_repo/lib/src/package_config.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ class Task {
412412
}
413413

414414
final extraConfig = Set<String>.from(yamlValue.keys)
415-
..removeAll([taskName, 'os', 'sdk', 'action']);
415+
..removeAll([taskName, 'os', 'sdk']);
416416

417417
// TODO(kevmoo): at some point, support custom configuration here
418418
if (extraConfig.isNotEmpty) {

mono_repo/test/mono_config_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,11 +417,10 @@ stages:
417417
- test #no args
418418
- group:
419419
- github_action:
420-
run: npm run build
421420
uses: actions/setup-node@v3
422421
with:
423422
node-version: 16
424-
working-directory: ./src
423+
- command: npm run build
425424
- test: --platform node
426425
''';
427426

@@ -623,6 +622,7 @@ List get _testConfig1expectedOutput => [
623622
'stageName': 'unit_test',
624623
'tasks': [
625624
{'flavor': 'dart', 'type': 'github_action'},
625+
{'flavor': 'dart', 'type': 'command', 'args': 'npm run build'},
626626
{
627627
'flavor': 'dart',
628628
'type': 'test',
@@ -638,6 +638,7 @@ List get _testConfig1expectedOutput => [
638638
'stageName': 'unit_test',
639639
'tasks': [
640640
{'flavor': 'dart', 'type': 'github_action'},
641+
{'flavor': 'dart', 'type': 'command', 'args': 'npm run build'},
641642
{
642643
'flavor': 'dart',
643644
'type': 'test',
@@ -653,6 +654,7 @@ List get _testConfig1expectedOutput => [
653654
'stageName': 'unit_test',
654655
'tasks': [
655656
{'flavor': 'dart', 'type': 'github_action'},
657+
{'flavor': 'dart', 'type': 'command', 'args': 'npm run build'},
656658
{
657659
'flavor': 'dart',
658660
'type': 'test',

0 commit comments

Comments
 (0)