[UI] fix linter warnings (#23101)

* all tests fixed

* code cleanup

* fix minor issue

* adds changelog

* remove redundant fn usage

* fixes assert equal issues

* ppnpm lock update

* avoid crashing on error

* fixes lint issue

* revert

* test change

* fix torii provider baseUrl assertion without changing SSO flow

* linting fix

* turn on linting rule classic-decorator-no-clasic-methods

* turn on linting rule classic-decorator-hooks

* turn on linting rule no-empty-glimmer-component-classes

* turn on linting rule no-legacy-test-waiters

* turn on linting rule ember/no-test-import-export

* fix some instances of no-get

* fixes for lint rule no-computed-properties-in-native-classes

* fix lint rule require-computed-property-dependencies

* turn on lint rule require-super-in-lifecycle-hooks

* turn on lint rule require-computed-macros

* fix deprecation implicit-injections

* remove deprecated package usage @ember/error deprecate-ember-error

Author: rishabh-gupta-hashicorp

ui/packages/consul-ui/.eslintrc.js

@@ -31,24 +31,25 @@ module.exports = {
     'ember/no-new-mixins': ['warn'],
 
     // for 3.24 update
-    'ember/classic-decorator-no-classic-methods': ['warn'],
-    'ember/classic-decorator-hooks': ['warn'],
+    'ember/classic-decorator-no-classic-methods': ['error'],
+    'ember/classic-decorator-hooks': ['error'],
     'ember/no-classic-classes': ['warn'],
     'ember/no-mixins': ['warn'],
     'ember/no-computed-properties-in-native-classes': ['warn'],
     'ember/no-private-routing-service': ['warn'],
-    'ember/no-test-import-export': ['warn'],
+    'ember/no-test-import-export': ['error'],
     'ember/no-actions-hash': ['warn'],
     'ember/no-classic-components': ['warn'],
     'ember/no-component-lifecycle-hooks': ['warn'],
     'ember/require-tagless-components': ['warn'],
-    'ember/no-legacy-test-waiters': ['warn'],
-    'ember/no-empty-glimmer-component-classes': ['warn'],
+    'ember/no-legacy-test-waiters': ['error'],
+    'ember/no-empty-glimmer-component-classes': ['error'],
     'ember/no-get': ['off'], // be careful with autofix, might change behavior
-    'ember/require-computed-property-dependencies': ['off'], // be careful with autofix
-    'ember/use-ember-data-rfc-395-imports': ['off'], // be carful with autofix
-    'ember/require-super-in-lifecycle-hooks': ['off'], // be careful with autofix
-    'ember/require-computed-macros': ['off'], // be careful with autofix
+    'ember/require-computed-property-dependencies': ['error'], // be careful with autofix
+    'ember/use-ember-data-rfc-395-imports': ['error'], // be carful with autofix
+    'ember/require-super-in-lifecycle-hooks': ['error'], // be careful with autofix
+    'ember/require-computed-macros': ['error'], // be careful with autofix
+    'ember/use-brace-expansion': 'off',
   },
   overrides: [
     // node files

ui/packages/consul-ui/app/abilities/base.js

@@ -4,8 +4,8 @@
  */
 
 import { inject as service } from '@ember/service';
-import { get } from '@ember/object';
 import Ability from 'ember-can/ability';
+import classic from 'ember-classic-decorator';
 
 export const ACCESS_READ = 'read';
 export const ACCESS_WRITE = 'write';
@@ -18,6 +18,7 @@ export const ACCESS_LIST = 'list';
 // permissions list. This is also fine for permission inspection for single
 // items/models as we only request the permissions for the namespace you are
 // in, we don't need to recheck that namespace here
+@classic
 export default class BaseAbility extends Ability {
   @service('repository/permission') permissions;
 
@@ -59,7 +60,7 @@ export default class BaseAbility extends Ability {
 
   get canRead() {
     if (typeof this.item !== 'undefined') {
-      const perm = (get(this, 'item.Resources') || []).find((item) => item.Access === ACCESS_READ);
+      const perm = (this.item?.Resources || []).find((item) => item.Access === ACCESS_READ);
       if (perm) {
         return perm.Allow;
       }
@@ -69,7 +70,7 @@ export default class BaseAbility extends Ability {
 
   get canList() {
     if (typeof this.item !== 'undefined') {
-      const perm = (get(this, 'item.Resources') || []).find((item) => item.Access === ACCESS_LIST);
+      const perm = (this.item?.Resources || []).find((item) => item.Access === ACCESS_LIST);
       if (perm) {
         return perm.Allow;
       }
@@ -79,7 +80,7 @@ export default class BaseAbility extends Ability {
 
   get canWrite() {
     if (typeof this.item !== 'undefined') {
-      const perm = (get(this, 'item.Resources') || []).find((item) => item.Access === ACCESS_WRITE);
+      const perm = (this.item?.Resources || []).find((item) => item.Access === ACCESS_WRITE);
       if (perm) {
         return perm.Allow;
       }

ui/packages/consul-ui/app/abilities/intention.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class IntentionAbility extends BaseAbility {
   resource = 'intention';
 

ui/packages/consul-ui/app/abilities/kv.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility, { ACCESS_LIST } from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class KVAbility extends BaseAbility {
   resource = 'key';
 

ui/packages/consul-ui/app/abilities/node.js

@@ -3,8 +3,10 @@
  * SPDX-License-Identifier: BUSL-1.1
  */
 
+import classic from 'ember-classic-decorator';
 import BaseAbility from './base';
 
+@classic
 export default class NodeAbility extends BaseAbility {
   resource = 'node';
 }

ui/packages/consul-ui/app/abilities/permission.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class PermissionAbility extends BaseAbility {
   get canRead() {
     return this.permissions.permissions.length > 0;

ui/packages/consul-ui/app/abilities/server.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class ServerAbility extends BaseAbility {
   resource = 'operator';
   segmented = false;

ui/packages/consul-ui/app/abilities/service-instance.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility, { ACCESS_READ, ACCESS_WRITE } from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class ServiceInstanceAbility extends BaseAbility {
   resource = 'service';
   generateForSegment(segment) {

ui/packages/consul-ui/app/abilities/session.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class SessionAbility extends BaseAbility {
   resource = 'session';
 }

ui/packages/consul-ui/app/abilities/upstream.js

@@ -4,7 +4,9 @@
  */
 
 import BaseAbility from './base';
+import classic from 'ember-classic-decorator';
 
+@classic
 export default class UpstreamAbility extends BaseAbility {
   resource = 'upstream';