fixes some node issues

Author: rishabh-gupta-hashicorp

ui/packages/consul-ui/app/components/data-sink/index.js

@@ -21,13 +21,10 @@ export default Component.extend({
 
   state: computed('instance', 'instance.{dirtyType,isSaving}', {
     get() {
-      if (this._state !== undefined) {
-        return this._state;
-      }
-
       let id;
       const isSaving = get(this, 'instance.isSaving');
       const dirtyType = get(this, 'instance.dirtyType');
+      
       if (typeof isSaving === 'undefined' && typeof dirtyType === 'undefined') {
         id = 'idle';
       } else {
@@ -45,18 +42,14 @@ export default Component.extend({
         }
         id = `active.${id}`;
       }
-      
-      const stateObj = {
+
+      return {
         matches: (name) => id.indexOf(name) !== -1,
       };
-
-      this._state = stateObj; // optional cache
-      return stateObj;
     },
 
     set(_key, value) {
-      this._state = value;
-      return this._state;
+      return value;
     },
   }),
 

ui/packages/consul-ui/app/components/list-collection/index.js

@@ -50,26 +50,17 @@ export default Component.extend(Slotted, {
 
   style: computed('height', {
     get() {
-      if (this._style !== undefined) {
-        return this._style;
-      }
-
-      let styleValue;
       if (this.scroll !== 'virtual') {
-        styleValue = {};
+        return {};
       } else {
-        styleValue = {
+        return {
           height: this.height,
         };
       }
-
-      this._style = styleValue; // optional caching
-      return styleValue;
     },
 
     set(_key, value) {
-      this._style = value;
-      return this._style;
+      return value;
     },
   }),
 

ui/packages/consul-ui/app/components/tabular-collection/index.js

@@ -42,10 +42,6 @@ export default CollectionComponent.extend(Slotted, {
 
   style: computed('rowHeight', '_items', 'maxRows', 'maxHeight', {
     get() {
-      if (this._style !== undefined) {
-        return this._style;
-      }
-
       const maxRows = this.rows;
       let height = this.maxHeight;
 
@@ -55,13 +51,11 @@ export default CollectionComponent.extend(Slotted, {
         height = this.rowHeight * rows + 29;
       }
 
-      this._style = { height }; // optional caching
-      return this._style;
+      return { height };
     },
 
     set(_key, value) {
-      this._style = value;
-      return this._style;
+      return value;
     },
   }),
 

ui/packages/consul-ui/app/models/intention-permission-http-header.js

@@ -44,6 +44,5 @@ export default class IntentionPermission extends Fragment {
   set HeaderType(value) {
     // Store manual override
     this._headerTypeManual = value;
-    return value;
   }
 }

ui/packages/consul-ui/app/models/intention-permission-http.js

@@ -41,6 +41,5 @@ export default class IntentionPermissionHttp extends Fragment {
   set PathType(value) {
     // Store manual override
     this._pathTypeManual = value;
-    return value;
   }
 }