Skip to content

UI/Deprecation Computed property override #22947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rishabh-gupta-hashicorp merged 5 commits into from
Oct 22, 2025
Merged

UI/Deprecation Computed property override #22947

rishabh-gupta-hashicorp merged 5 commits into from
Oct 22, 2025
+146 −66

Conversation

@rishabh-gupta-hashicorp
Copy link
Contributor

@rishabh-gupta-hashicorp rishabh-gupta-hashicorp commented Oct 15, 2025

Description

https://deprecations.emberjs.com/id/computed-property-override/

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@rishabh-gupta-hashicorp rishabh-gupta-hashicorp added the backport/all Apply backports for all active releases per .release/versions.hcl label Oct 15, 2025
@github-actions github-actions bot added the theme/ui Anything related to the UI label Oct 15, 2025
@suresh-hashicorp suresh-hashicorp changed the base branch from main to ui/fix-deprecations October 16, 2025 06:08
@suresh-hashicorp suresh-hashicorp force-pushed the rishabh-gupta/ui/deprecation-computed-property-override branch from 2d564ed to dc206d7 Compare October 16, 2025 06:08
@suresh-hashicorp suresh-hashicorp enabled auto-merge (squash) October 16, 2025 08:04
@rishabh-gupta-hashicorp rishabh-gupta-hashicorp changed the base branch from ui/fix-deprecations to main October 16, 2025 09:37
@rishabh-gupta-hashicorp rishabh-gupta-hashicorp force-pushed the rishabh-gupta/ui/deprecation-computed-property-override branch from f1d6f86 to 5c353fe Compare October 17, 2025 07:43
@rishabh-gupta-hashicorp rishabh-gupta-hashicorp merged commit 0879750 into main Oct 22, 2025
74 checks passed
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.21 This release series is longer active on CE, use backport/ent/1.21 backport/1.22 Changes are backported to 1.22 backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/ent/1.20 backport to ent 1.20 labels Oct 22, 2025
This was referenced Oct 22, 2025
Closed
Merged
rishabh-gupta-hashicorp added a commit that referenced this pull request Oct 22, 2025
@rishabh-gupta-hashicorp
UI/Deprecation Computed property override (#22947)
ce89bb9 
* fixes computed property override deprecations and some issues pre-emptively

* fixes some node issues

* adds changelog

* linting fixes
rishabh-gupta-hashicorp added a commit that referenced this pull request Oct 22, 2025
@rishabh-gupta-hashicorp
UI/Deprecation Computed property override backport into 1.21.x (#22947)…
9a2570f 
… (#22960)

UI/Deprecation Computed property override (#22947)

* fixes computed property override deprecations and some issues pre-emptively

* fixes some node issues

* adds changelog

* linting fixes
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 12, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

29 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 13, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 14, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 15, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 16, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 17, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 18, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 19, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 20, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 21, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 22, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 23, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 24, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 25, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 26, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 27, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 28, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 29, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Nov 30, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 1, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 2, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 3, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 4, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 6, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 7, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 8, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 9, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 10, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 11, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 12, 2025

📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22947] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suresh-hashicorp suresh-hashicorp suresh-hashicorp approved these changes

Assignees

No one assigned

Labels

backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/ent/1.20 backport to ent 1.20 backport/1.21 This release series is longer active on CE, use backport/ent/1.21 backport/1.22 Changes are backported to 1.22 theme/ui Anything related to the UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishabh-gupta-hashicorp @hc-github-team-consul-core @suresh-hashicorp