Feature Request: Automatic Docker Imaging

[leshicodes]

First of all, thank you for creating Wingfit! I noticed that you already have a Docker workflow setup with GitHub Actions that builds and publishes images to GHCR on tag pushes. I'd like to contribute by enhancing this automation system to make it more robust and flexible.

Proposal

Container Registry Agnostic

• Add Docker Hub publishing alongside GitHub Container Registry
• Implement proper authentication and secret management for both registries

Enhanced Versioning

• Generate Docker tags based on semantic versioning
• Add build date and Git commit labels to images for better traceability

Optimization

• Enhance layer caching in the Dockerfile
• Implement multi-stage builds to reduce final image size
• Add (optional?) healthcheck to the container

Build Configurations

• Create separate production and development builds
• Add architecture-specific builds (amd64, arm64)

Plan

1. .github\workflows\docker-publish.yml:

name: Build and Deploy Docker

on:
  push:
    tags:
      - 'v*.*.*'  # Semantic version tags
    branches:
      - main  # Optional: build dev images from main branch

env:
  REGISTRY_GHCR: ghcr.io
  REGISTRY_DOCKER: docker.io
  IMAGE_NAME: ${{ github.repository }}

jobs:
  # Enhanced build job with multi-registry support

2. Creating Docker Hub secrets in the repository settings
3. Improving the Dockerfile for better caching and optimization
4. Adding docs abt the new Docker image versioning strategy

[itskovacs]

Afternoon @leshicodes 👋,

Sorry for the response delay, I’m easing off a bit on Wingfit before picking things back up more actively after summer.

First off, really appreciate you taking the time for this and for your interest in Wingfit 🙌.

To understand better, I do have a quick question, since GHCR is already integrated and works seamlessly with GitHub Actions, what would be the added value of also pushing to Docker Hub?

If i'm correct, users can already pull the image from the packages using the docker pull (though by prepending with ghcr.io/itskovacs/). I’m still learning my way around CI/CD, just trying to get a fuller picture before jumping in.

Again, thanks for your interest and your time 🤝

[leshicodes]

Howdy @itskovacs ,

Thanks for the response! Totally understand taking a summer break from the project. I have been focusing on my Terrariums and garden :) Great for the soul.

So to answer the question...

... what would be the added value of also pushing to Docker Hub?

• Many users are more familiar with Docker Hub and might instinctively search there first (that's what I did!)
• I (PERSONALLY) don't like github container registry. I find it cumbersome to look for tags, and there is a requirement to be authed for API queries, even GETs.
• Docker Hub has better public discoverability for users who aren't coming directly from GitHub
• Having multiple registries provides a backup in case one has issues

That said, you're absolutely right that GHCR already provides the core functionality needed, and the ghcr.io/itskovacs/wingfit syntax is straightforward.

The feature req for docker hub might add un-needed complexity in your eyes, which I would totally respect! However I would implore you to look into the below as well.

1. Enhanced Versioning Strategy

   • Currently tags just mirror Git tags - we could implement semantic versioning
   • Example: A v1.2.3 tag would generate images tagged as latest, 1, 1.2, and 1.2.3
   • This lets users choose stability level (latest vs specific version)

2. Build Optimizations

   • Enhance Dockerfile for better layer caching and smaller final images
   • Add container labels for better versioning information (build date, git commit)
   • Add container healthchecks

Mostly just nitpicks and admittedly unsolicited advice from stuff I've learned over my years of DevOps and Software Development. Just my $0.02 !

[itskovacs]

👋,

Thank you so much for this detailed answer! There's always so much to learn from others, and this is yet another reminder that the road ahead is long, but exciting.
Also, terrariums sound like a seriously underrated self-care hobby 🌱

You brought up some really interesting points. I wasn't aware of the API query constraints on GHCR, and I hadn't considered the redundancy/backup angle either, that's a great insight. To be honest, the CI package was only implemented a few days ago, following FT #37, as this has been on the roadmap for quite a while now.

Your suggestions around enhanced versioning and Docker optimizations are as well a spot-on. These are exactly the kind of improvements that, IMO, make a tool feel more polished and reliable, even if they're just the very very tip of the iceberg.

I'll definitely add these to the roadmap and aim to implement them as soon as I can carve out some time! I've recently been focusing more on my other app, 🗺️ TRIP, but the work I'm doing there translates really well to Wingfit (and vice versa), so it's time well spent.

Sincerely, thank you for the generous knowledge-sharing 🙌, it really means a lot to see experienced devs take time and give feedback on my small projects, plus very actionable insights actually...

Looking forward to continuing this conversation very soon! 🚀

[itskovacs]

Example: A v1.2.3 tag would generate images tagged as latest, 1, 1.2, and 1.2.3

Just did this on my other project and indeed, it's an excellent idea !

I'm working on the Docker Hub publishing part 👍