Skip to content

Commit 6ce87ea

Browse files
Fix: Upgrade to node 24 (#3150)
## Which problem is this PR solving? - Resolves #3147 ## Description of the changes The React 19 validation error was caused by `react-side-effect` (a transitive dependency via react-helmet). Its `package.json`: ``` json"peerDependencies": { "react": "^16.3.0 || ^17.0.0 || ^18.0.0" } ``` The package does not support React 19. Our override successfully installed React 19. But `npm ls --all` do strict validation against the declared peer dependencies and make `React 19.2.0` as invalid. Proof: nfl/react-helmet#716 Solution: Added `react-side-effect` as a direct dependency in `package.json`. Now `npm` validates leniently, checking if React exists and is compatible -> passes with React 19. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Parship Chowdhury <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
1 parent fea7787 commit 6ce87ea

File tree

2 files changed

+216
-237
lines changed

2 files changed

+216
-237
lines changed

0 commit comments

Comments
 (0)