fix: remove circular dependency between obj and rec modules #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obj is the primitive concept (any non-null, non-array object), while rec is a refinement (plain objects only). The dependency should be one-way: rec → obj. Replaced type-only imports of Rec.Any and Rec.Value with built-in Record<PropertyKey, unknown> for internal casting. Closes #106
✅ Deploy Preview for wollybeard-kit canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
obj → rectype-only dependency that inverted the conceptual hierarchyobjis the primitive (any non-null, non-array object),recis the refinement (plain objects only)Rec.AnyandRec.Valuecasts withRecord<PropertyKey, unknown>Changes
src/domains/obj/obj.tsimport type { Rec }, replacedRec.Anycastsrc/domains/obj/merge.tsimport type { Rec }, replacedRec.ValuecastsTest plan
pnpm check:types)Closes #106