git remote: only check for an existing remote in local config when adding/renaming #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding/renaming cloning currently fails with Error: Git remote named '$remote' already exists if the user has some config somewhere that applies to $remote, e.g. in ~/.gitconfig. this error makes sense if you are trying to add a remote that already exists in the local config, but doesn't make sense while cloning since there must not be a local config this PR fixes the bug by only looking for configuration that originated from the local .git/config file
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopening #7860
cloning currently fails with
Error: Git remote named '$remote' already existsif the user has some config somewhere that applies to$remote, e.g. in ~/.gitconfig. this error makes sense if you are trying to add a remote that already exists in the local config, but doesn't make sense while cloning since there must not be a local configthis PR fixes the bug by only looking for configuration that originated from the local
.git/configfileChecklist
If applicable:
CHANGELOG.mdI have updated the documentation (README.md,docs/,demos/)I have updated the config schema (cli/src/config-schema.json)