Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 6, 2025

MD031/blanks-around-fences : Fenced code blocks should be surrounded by blank lines

@xtqqczze xtqqczze requested a review from a team as a code owner December 6, 2025 14:25
@xtqqczze xtqqczze enabled auto-merge December 6, 2025 14:25
@PhilipMetzger
Copy link
Contributor

PhilipMetzger commented Dec 6, 2025

if the project adopts a MD linter we first should find consensus on that before starting to apply it.

@martinvonz
Copy link
Member

I agree. But markdownlint seems to not be a formatters but a linter. We can adopt both a formatter and markdownlint, I suppose. markdownlint presumably doesn't make suggestions that would go against any particular formatter.

@steveklabnik
Copy link
Contributor

As a random aside, I've always written Markdown in this way, I suspect a lot of implementations these days would render without the spaces, but in the earlier days, many didn't.

I have no opinions on markdown linters or formatters, I haven't really used any myself.

@martinvonz
Copy link
Member

I have no objection to the changes here. It seems fine to even include the .markdownlint.json* files. That doesn't mean that we have agreed on using using markdownlint IMO, it's just there for convenience for those who do. What do you think, @PhilipMetzger ?

@PhilipMetzger
Copy link
Contributor

What do you think, @PhilipMetzger ?

I'm fine with the change, but I'd prefer to keep the configuration files out of the repo until there's some consensus around the tooling we want to use for markdown (linters and formatting).

[MD031/blanks-around-fences](https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md031.md) : Fenced code blocks should be surrounded by blank lines
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 8, 2025

7644a9b removed the .markdownlint.jsonc and .markdownlint.json files

@xtqqczze xtqqczze added this pull request to the merge queue Dec 8, 2025
Merged via the queue into jj-vcs:main with commit a88b119 Dec 9, 2025
30 checks passed
@xtqqczze xtqqczze deleted the markdownlint/MD031 branch December 9, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants