Add log for false and any-match scrubbing rule

Author: bozaro

src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java

@@ -61,10 +61,12 @@
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Maps;
 import com.google.common.eventbus.Subscribe;
+import com.google.common.flogger.GoogleLogger;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.SettableFuture;
 import com.google.devtools.build.lib.actions.ActionInput;
+import com.google.devtools.build.lib.actions.ActionOwner;
 import com.google.devtools.build.lib.actions.Artifact;
 import com.google.devtools.build.lib.actions.ArtifactPathResolver;
 import com.google.devtools.build.lib.actions.EnvironmentalExecException;
@@ -1983,7 +1985,7 @@ void report(Event evt) {
     }
   }
 
-  private static boolean hasScrubbedInput(Spawn spawn, @Nullable Scrubber scrubber) {
+  private boolean hasScrubbedInput(Spawn spawn, @Nullable Scrubber scrubber) {
     if (scrubber == null) {
       return false;
     }
@@ -2000,11 +2002,23 @@ private static boolean hasScrubbedInput(Spawn spawn, @Nullable Scrubber scrubber
       }
     }
     var inputFiles = spawn.getInputFiles();
+
+    String mnemonic = spawn.getMnemonic();
+    ActionOwner actionOwner = spawn.getResourceOwner().getOwner();
+    String label = actionOwner.getLabel().getCanonicalForm();
+    String kind = actionOwner.getTargetKind();
+
     for (ActionInput inputFile : inputFiles.toList()) {
       if (spawnScrubber.shouldOmitInput(inputFile.getExecPath())) {
+        if (!spawnScrubber.hasMatcher) {
+          reporter.handle(Event.warn(String.format("Used file-based scrubber for mnemonic: %s, label: %s, kind: %s", mnemonic, label, kind)));
+        }
         return true;
       }
     }
+    if (spawnScrubber.hasMatcher) {
+      reporter.handle(Event.warn(String.format("Unused scrubber for mnemonic: %s, label: %s, kind: %s", mnemonic, label, kind)));
+    }
     return false;
   }
 

src/main/java/com/google/devtools/build/lib/remote/Scrubber.java

@@ -110,6 +110,7 @@ public static class SpawnScrubber {
     private final ImmutableList<Pattern> omittedInputPatterns;
     private final ImmutableMap<Pattern, String> argReplacements;
     private final String salt;
+    public final boolean hasMatcher;
 
     private SpawnScrubber(Config.Rule ruleProto) {
       Config.Matcher matcherProto = ruleProto.getMatcher();
@@ -127,6 +128,7 @@ private SpawnScrubber(Config.Rule ruleProto) {
           transformProto.getArgReplacementsList().stream()
               .collect(toImmutableMap(r -> Pattern.compile(r.getSource()), r -> r.getTarget()));
       this.salt = ruleProto.getTransform().getSalt();
+      this.hasMatcher = ruleProto.hasMatcher();
     }
 
     private String emptyToAll(String s) {