Update switch styles #4836
Merged
Update switch styles #4836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LLM Analysis of PR ChangesSummaryThis PR updates the styles for the Key Points to Review
Style & Consistency
|
Deploying orbit with
|
| Latest commit: |
0389105
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e1e703d.orbit.pages.dev |
| Branch Preview URL: | https://dsil-update-switch-styles.orbit.pages.dev |
Contributor
|
Size Change: -45 B (-0.01%) Total Size: 472 kB
ℹ️ View Unchanged
|
Contributor
|
Storybook staging is available at https://kiwicom-orbit-dsil-update-switch-styles.surge.sh Playroom staging is available at https://kiwicom-orbit-dsil-update-switch-styles.surge.sh/playroom |
DSil
force-pushed
the
dsil/update-switch-styles
branch
from
611e7e4 to
0389105
Compare
sarkaaa
reviewed
Aug 20, 2025
sarkaaa
reviewed
Aug 20, 2025
Member
There was a problem hiding this comment.
from my POV the code is correct (excluding question/note above), however, I have a design-related note - when the old switch was checked && focused, the blue outline was visible, bcs the toggle was "overflowing" the blue area. now, when it's not overflowing, the blue outline is not visible when focused. I think designers should take this into mind and adjust.
Collaborator
Author
|
Agreed with the focus question. I also noticed it. Added it to the sync document |
sarkaaa
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Design, there is a new design for the Switch component.
Some snapshots needed an update as they were constantly failing. They are on a separate commit to avoid noise on the PR
FEPLT-2962
✨
Description by Callstackai
This PR updates the styles for the Switch component according to the new design specifications. It also includes new stories and tests for the Switch component.
Diagrams of code changes
sequenceDiagram participant User participant Switch participant Icon Note over Switch: Component can be checked/unchecked Note over Switch: Can be enabled/disabled User->>Switch: Interact with Switch alt is enabled Switch-->>User: Show clickable cursor User->>Switch: Toggle state Switch->>Switch: Update checked state alt has icon Switch->>Icon: Render icon Icon-->>Switch: Return icon component end Switch-->>User: Show updated state else is disabled Switch-->>User: Show not-allowed cursor Switch-->>User: Maintain current state end Note over Switch: Supports RTL layout Note over Switch: Animates state changesFiles Changed