Merge pull request #700 from saschagrunert/cors-fix

k8s-ci-robot · web-flow · commit be2cf6d7635e · 2024-11-21T08:48:54.000Z
Modify release notes link to the allowed CDN
diff --git a/src/app/notes/notes.service.ts b/src/app/notes/notes.service.ts
@@ -103,11 +103,12 @@ export class NotesService {
    * @returns Transformed URL
    */
   private cdnLinkFromGsPath(path: string): string {
+    const allowedCorsLink = 'cdn.dl.k8s.io';
     // Normalize the link if required
-    const regex = /^gs:\/\/[\w-/.]*\.json$/;
-    if (path.match(regex)) {
-      return path.replace(/^gs:\/\/[\w-]*\//, 'https://cdn.dl.k8s.io/');
+    if (path.match(/^gs:\/\/[\w-/.]*\.json$/)) {
+      return path.replace(/^gs:\/\/[\w-]*\//, `https://${allowedCorsLink}/`);
     }
-    return path;
+
+    return path.replace(/dl\.k8s\.io/, allowedCorsLink);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -103,11 +103,12 @@ export class NotesService {`
`103`	`103`	`* @returns Transformed URL`
`104`	`104`	`*/`
`105`	`105`	`private cdnLinkFromGsPath(path: string): string {`
	`106`	`+ const allowedCorsLink = 'cdn.dl.k8s.io';`
`106`	`107`	`// Normalize the link if required`
`107`		`- const regex = /^gs:\/\/[\w-/.]*\.json$/;`
`108`		`- if (path.match(regex)) {`
`109`		`- return path.replace(/^gs:\/\/[\w-]*\//, 'https://cdn.dl.k8s.io/');`
	`108`	`+ if (path.match(/^gs:\/\/[\w-/.]*\.json$/)) {`
	`109`	+ return path.replace(/^gs:\/\/[\w-]*\//, `https://${allowedCorsLink}/`);
`110`	`110`	`}`
`111`		`- return path;`
	`111`	`+`
	`112`	`+ return path.replace(/dl\.k8s\.io/, allowedCorsLink);`
`112`	`113`	`}`
`113`	`114`	`}`