Remove use of deprecated NewSimpleClientset

Only for upstream dependencies

Author: adrianmoisey

vertical-pod-autoscaler/pkg/admission-controller/certs_test.go

@@ -193,7 +193,7 @@ func TestChangedCAReloader(t *testing.T) {
 		t.Error(err)
 	}
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 
 	selfRegistration(
 		testClientSet,
@@ -309,7 +309,7 @@ func TestChangedCAReloader(t *testing.T) {
 // 		t.Error(err)
 // 	}
 
-// 	testClientSet := fake.NewSimpleClientset()
+// 	testClientSet := fake.fake.NewClientset()
 
 // 	selfRegistration(
 // 		testClientSet,

vertical-pod-autoscaler/pkg/admission-controller/config_test.go

@@ -29,7 +29,7 @@ import (
 
 func TestSelfRegistrationBase(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -73,7 +73,7 @@ func TestSelfRegistrationBase(t *testing.T) {
 
 func TestSelfRegistrationWithURL(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -101,7 +101,7 @@ func TestSelfRegistrationWithURL(t *testing.T) {
 
 func TestSelfRegistrationWithOutURL(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -131,7 +131,7 @@ func TestSelfRegistrationWithOutURL(t *testing.T) {
 
 func TestSelfRegistrationWithIgnoredNamespaces(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -162,7 +162,7 @@ func TestSelfRegistrationWithIgnoredNamespaces(t *testing.T) {
 
 func TestSelfRegistrationWithSelectedNamespaces(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -194,7 +194,7 @@ func TestSelfRegistrationWithSelectedNamespaces(t *testing.T) {
 
 func TestSelfRegistrationWithFailurePolicy(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -221,7 +221,7 @@ func TestSelfRegistrationWithFailurePolicy(t *testing.T) {
 
 func TestSelfRegistrationWithOutFailurePolicy(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"
@@ -248,7 +248,7 @@ func TestSelfRegistrationWithOutFailurePolicy(t *testing.T) {
 
 func TestSelfRegistrationWithInvalidLabels(t *testing.T) {
 
-	testClientSet := fake.NewSimpleClientset()
+	testClientSet := fake.NewClientset()
 	caCert := []byte("fake")
 	webHookDelay := 0 * time.Second
 	namespace := "default"

vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder_test.go

@@ -858,7 +858,7 @@ func TestFilterVPAsIgnoreNamespaces(t *testing.T) {
 
 func TestCanCleanupCheckpoints(t *testing.T) {
 	_, tctx := ktesting.NewTestContext(t)
-	client := fake.NewSimpleClientset()
+	client := fake.NewClientset()
 	namespace := "testNamespace"
 
 	_, err := client.CoreV1().Namespaces().Create(tctx, &v1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: namespace}}, metav1.CreateOptions{})

vertical-pod-autoscaler/pkg/updater/logic/updater_test.go

@@ -453,7 +453,7 @@ func TestRunOnceIgnoreNamespaceMatching(t *testing.T) {
 }
 
 func TestNewEventRecorder(t *testing.T) {
-	fakeClient := fake.NewSimpleClientset()
+	fakeClient := fake.NewClientset()
 	er := newEventRecorder(fakeClient)
 
 	maxRetries := 5

vertical-pod-autoscaler/pkg/utils/limitrange/limit_range_calculator_test.go

@@ -38,7 +38,7 @@ func TestNewNoopLimitsChecker(t *testing.T) {
 }
 
 func TestNoLimitRange(t *testing.T) {
-	cs := fake.NewSimpleClientset()
+	cs := fake.NewClientset()
 	factory := informers.NewSharedInformerFactory(cs, 0)
 	lc, err := NewLimitsRangeCalculator(factory)
 
@@ -133,7 +133,7 @@ func TestGetContainerLimitRangeItem(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			cs := fake.NewSimpleClientset(tc.limitRanges...)
+			cs := fake.NewClientset(tc.limitRanges...)
 			factory := informers.NewSharedInformerFactory(cs, 0)
 			lc, err := NewLimitsRangeCalculator(factory)
 

vertical-pod-autoscaler/pkg/utils/status/status_object_test.go

@@ -129,7 +129,7 @@ func TestUpdateStatus(t *testing.T) {
 	}
 	for _, tc := range tests {
 		t.Run(fmt.Sprintf("test case: %s", tc.name), func(t *testing.T) {
-			fc := fake.NewSimpleClientset()
+			fc := fake.NewClientset()
 			fc.PrependReactor("get", "leases", tc.updateReactor)
 			fc.PrependReactor("create", "leases", tc.updateReactor)
 			fc.PrependReactor("update", "leases", tc.updateReactor)
@@ -204,7 +204,7 @@ func TestGetStatus(t *testing.T) {
 	}
 	for _, tc := range tests {
 		t.Run(fmt.Sprintf("test case: %s", tc.name), func(t *testing.T) {
-			fc := fake.NewSimpleClientset()
+			fc := fake.NewClientset()
 			fc.PrependReactor("get", "leases", tc.getReactor)
 			client := NewClient(fc, leaseName, leaseNamespace, 10*time.Second, leaseName)
 			_, err := client.getStatus(context.Background())