-
Notifications
You must be signed in to change notification settings - Fork 4.3k
CA: update k8s deps to 1.35.0-rc.0 #8827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2ece218 to
8d755e8
Compare
8d755e8 to
89052b8
Compare
|
That is fine. I will rebase. |
| assert.NotNil(t, predicateErr) | ||
| assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint {SomeTaint: WhyNot?}") | ||
| assert.Contains(t, predicateErr.Error(), "node(s) had untolerated taint {SomeTaint: WhyNot?}") | ||
| assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint(s)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credit to @gnufied for saving me time having to figure out this one 🙏
|
/test pull-cluster-autoscaler-e2e-azure-master |
9674aca to
cadb707
Compare
|
looks like an error with a /retest |
cadb707 to
c00e24d
Compare
52c809a to
8b61927
Compare
|
/retitle CA: update k8s deps to 1.35.0-rc.0 |
|
/label tide/merge-method-squash |
Let's do that in a follow-up (prior to 1.35.0 CA release) so we can land this ASAP and unblock @gnufied |
|
/lgtm |
|
/hold for E2E |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
4ed8aa8 to
cd44ce3
Compare
|
@jackfrancis: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR brings in the 1.35 Kubernetes deps in preparation for a 1.35 release of CA.
Which issue(s) this PR fixes:
Fixes #8742
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: