Skip to content

Conversation

@jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Nov 19, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR brings in the 1.35 Kubernetes deps in preparation for a 1.35 release of CA.

Which issue(s) this PR fixes:

Fixes #8742

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update k8s deps to 1.35.0-alpha.3

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2025
@jackfrancis jackfrancis force-pushed the ca-1.35.0-alpha.3 branch 6 times, most recently from 2ece218 to 8d755e8 Compare November 19, 2025 18:56
@jackfrancis
Copy link
Contributor Author

@towca this PR aims to bring in the DeviceClassResolver addition w/ the 1.35 k8s dependencies

cc @gnufied you should be able to rebase your CSI changs on top of this (it will be better to have a discrete PR that brings in changes from updates to k8s dependencies)

@gnufied
Copy link
Member

gnufied commented Nov 19, 2025

That is fine. I will rebase.

assert.NotNil(t, predicateErr)
assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint {SomeTaint: WhyNot?}")
assert.Contains(t, predicateErr.Error(), "node(s) had untolerated taint {SomeTaint: WhyNot?}")
assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint(s)")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credit to @gnufied for saving me time having to figure out this one 🙏

@jackfrancis
Copy link
Contributor Author

/test pull-cluster-autoscaler-e2e-azure-master

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/provider/azure Issues or PRs related to azure provider labels Nov 19, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@elmiko
Copy link
Contributor

elmiko commented Nov 19, 2025

looks like an error with a go.sum file, but the units are fine.

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 5, 2025
@jackfrancis
Copy link
Contributor Author

/retitle CA: update k8s deps to 1.35.0-rc.0

@k8s-ci-robot k8s-ci-robot changed the title CA: update k8s deps to 1.35.0-beta.0 CA: update k8s deps to 1.35.0-rc.0 Dec 5, 2025
@jackfrancis
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 5, 2025
@jackfrancis
Copy link
Contributor Author

@jackfrancis Did you end up figuring out the DRA enablement issue? We could technically replace the feature-gate-based defaulting logic with actually explicitly modifying the scheduler config to add/remove the DRA plugin used to create the scheduler framework. But it probably makes more sense to just drop it and always include the plugin at this point, WDYT?

Left some non-blocking comments, but in general LGTM! Thanks for taking care of this Jack!

/lgtm

Let's do that in a follow-up (prior to 1.35.0 CA release) so we can land this ASAP and unblock @gnufied

@gnufied
Copy link
Member

gnufied commented Dec 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
@jackfrancis
Copy link
Contributor Author

/hold for E2E

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@elmiko
Copy link
Contributor

elmiko commented Dec 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

@jackfrancis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-autoscaler-e2e-azure-master 1ffecac link false /test pull-cluster-autoscaler-e2e-azure-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/helm-charts area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CA DRA: implement DeviceClassResolver()

5 participants