feat(frontend/tf): add RemoveInheritedTagsVisitor #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
force-pushed
the
remove-inherited-tags
branch
from
7eefa33 to
7e06b1f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 17.63% 17.63%
=======================================
Files 103 103
Lines 9317 9361 +44
=======================================
+ Hits 1643 1651 +8
- Misses 7579 7615 +36
Partials 95 95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An inherited tag is a tag in a span/log that also appears in its parent/owning span with the same key and value.
These tags are often useless and may be removed for brevity.
Related issues
Special notes for your reviewer: